You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2024/11/15 01:08:21 UTC
[PR] chore: bump last instance of `actions/*-artifact` to v4 [arrow-adbc]
assignUser opened a new pull request, #2329:
URL: https://github.com/apache/arrow-adbc/pull/2329
This instance was merged a day after everything else was bumped and as the dependabot PR was closed it's ignoring it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump last instance of `actions/*-artifact` to v4 [arrow-adbc]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #2329:
URL: https://github.com/apache/arrow-adbc/pull/2329#discussion_r1843108557
##########
.github/workflows/packaging.yml:
##########
@@ -167,8 +168,9 @@ jobs:
echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
+ name: go-ubuntu-latest
Review Comment:
(`merge_multiple: true` was the silent default)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump last instance of `actions/*-artifact` to v4 [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #2329:
URL: https://github.com/apache/arrow-adbc/pull/2329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump last instance of `actions/*-artifact` to v4 [arrow-adbc]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #2329:
URL: https://github.com/apache/arrow-adbc/pull/2329#discussion_r1843084155
##########
.github/workflows/packaging.yml:
##########
@@ -167,8 +168,9 @@ jobs:
echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
+ name: go-ubuntu-latest
Review Comment:
Not sure how this worked out with the clobbering? Lucky timing maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump last instance of `actions/*-artifact` to v4 [arrow-adbc]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #2329:
URL: https://github.com/apache/arrow-adbc/pull/2329#discussion_r1843083944
##########
.github/workflows/packaging.yml:
##########
@@ -132,8 +132,9 @@ jobs:
popd
- name: Upload Go binaries
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
+ name: go-${{ matrix.os }}
Review Comment:
v4 errors on default when clobbering files of the same name, as this is a matrix job it was happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org