You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:36:13 UTC
Review Request 65916: Set Docker info for the test
`TaskUsesDockerContainerInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65916/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-8640
https://issues.apache.org/jira/browse/MESOS-8640
Repository: mesos
Description
-------
Docker info is required when container's type is DOCKER, it is enforced
in `mesos::internal::common::validation:validateContainerInfo()`. So in
this test, we have to set Docker info to pass the validation.
Diffs
-----
src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
Diff: https://reviews.apache.org/r/65916/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65916: Set Docker info for the test
`TaskUsesDockerContainerInfo`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65916/#review199054
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 5, 2018, 11:36 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65916/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 11:36 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8640
> https://issues.apache.org/jira/browse/MESOS-8640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Docker info is required when container's type is DOCKER, it is enforced
> in `mesos::internal::common::validation:validateContainerInfo()`. So in
> this test, we have to set Docker info to pass the validation.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65916/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>