[GitHub] [incubator-doris] morningman commented on a change in pull request #2522: Alter view stmt

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2522: Alter view stmt
URL: https://github.com/apache/incubator-doris/pull/2522#discussion_r360838955
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -4825,6 +4833,50 @@ public void replayRenameTable(TableInfo tableInfo) throws DdlException {
         }
     }
 
+    public void modifyViewDef(Database db, View view, String inlineViewDef) throws DdlException {
+        String viewName = view.getName();
+
+        db.dropTable(viewName);
 
 Review comment:
   > I think we should make drop table and create view an atomic operation. Otherwise after view is dropped, concurrent query may create another view, which would make this operation fail.
   
   It is atomic, cause it hold the db's writelock before calling this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org