[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6841: default should map always, not require the minHypervisorVersion

["rohityadavcloud (via GitHub)" <gi...@apache.org>]

rohityadavcloud commented on code in PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#discussion_r1187113496


##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -157,7 +157,7 @@ public List<GuestOSHypervisorVO> listByOsNameAndHypervisorMinimumVersion(String
         sc.and(sc.entity().getGuestOsName(), SearchCriteria.Op.EQ, guestOsName);
         sc.and(sc.entity().getHypervisorType(), SearchCriteria.Op.EQ, hypervisorType);
         sc.and().op(sc.entity().getHypervisorVersion(), SearchCriteria.Op.GTEQ, minHypervisorVersion);
-        sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.NEQ, "default");
+        sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.EQ, "default");

Review Comment:
   should this be GTEQ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org