You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by c0s <gi...@git.apache.org> on 2016/02/12 15:32:26 UTC
[GitHub] incubator-hawq pull request: No need to use ksh and add an extra r...
GitHub user c0s opened a pull request:
https://github.com/apache/incubator-hawq/pull/339
No need to use ksh and add an extra runtime dep
Why a single file in the whole project will be using ksh without any ksh specific functionality it might need?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/c0s/incubator-hawq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #339
----
commit 9fa5e8539e218701b9df18eeab146d82d7e0bf7a
Author: Cos <co...@apache.org>
Date: 2016-02-12T14:31:45Z
No need to use ksh and add an extra runtime dep
Why a single file in the whole project will be using ksh without any ksh specific functionality it might need?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #339: No need to use ksh and add an extra runtim...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: No need to use ksh and add an extra r...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the pull request:
https://github.com/apache/incubator-hawq/pull/339#issuecomment-209570961
@rvs Is this merged into master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #339: No need to use ksh and add an extra runtime dep
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/339
I tested the changes on RHEL6.5, seems many command in the scripts not available.
And as my check, no others using this script. And this feature of this script is not important. It just do a simple test of disk speed.
So I suggest we remove this file.
[gpadmin@test1 bin]$ ./diskqual.ksh
./diskqual.ksh: line 2: format: command not found
./diskqual.ksh: line 2: nawk: command not found
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: No need to use ksh and add an extra r...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/incubator-hawq/pull/339#issuecomment-209574092
No, 2 months later it is still sitting in the queue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: No need to use ksh and add an extra r...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the pull request:
https://github.com/apache/incubator-hawq/pull/339#issuecomment-183419218
LGTM. Unless somebody complains I'll be merging this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #339: No need to use ksh and add an extra runtime dep
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/339
@c0s - can you please update this PR to essentially remove the file altogether? It is not needed in the HAWQ context.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---