You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by GitBox <gi...@apache.org> on 2018/09/27 14:53:59 UTC
[GitHub] tttMelody commented on a change in pull request #248: KYLIN-3588, fix potentially duplicate putting in RemoveBlackoutRealiz…
tttMelody commented on a change in pull request #248: KYLIN-3588, fix potentially duplicate putting in RemoveBlackoutRealiz…
URL: https://github.com/apache/kylin/pull/248#discussion_r220956979
##########
File path: query/src/main/java/org/apache/kylin/query/routing/rules/RemoveBlackoutRealizationsRule.java
##########
@@ -58,14 +58,16 @@ public static boolean accept(IRealization real) {
private static IRealizationFilter getFilterImpl(KylinConfig conf) {
IRealizationFilter filter = filters.get(conf);
- if (filter == null) {
- try {
- Class<? extends IRealizationFilter> clz = ClassUtil.forName(conf.getQueryRealizationFilter(), IRealizationFilter.class);
- filter = clz.getConstructor(KylinConfig.class).newInstance(conf);
- } catch (Exception e) {
- throw new RuntimeException(e);
+ synchronized (RemoveBlackoutRealizationsRule.class) {
Review comment:
Thanks shaofeng! I'll refine this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services