You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Antonio <an...@vieiro.net> on 2017/10/21 08:34:22 UTC
Heads up: Missing patches for external binary
Hi all,
I'm trying to build the external binary for the o.apache.xml.resolver
module.
- Problem:
This module has a patch file [1] that works against xml-commons/resolver
version 1.1 (2003)
In 2009 (see [2]) "a new method was added to
org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version
1.2. I do have a patch for that, no worries here.
But also "two new classes org.apache.xml.resolver.NbCatalogManager.java"
and "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to
the external binary ([2]).
And I'm afraid these are gone forever. There's no patch for those and
they're not kept in the NetBeans repository.
- Proposed solution:
I think I should try to decompile and recover those sources from the
existing binary kept in NetBeans hg repositories and build a patch for
those new sources.
- Questions:
a) This is OK for you, right?
b) I assume nobody has the source code for
org.apache.xml.resolver.NbCatalogManager nor
org.apache.xml.resolver.NbCatalogResolver somewhere, right?
Thanks,
Antonio
[1]
https://github.com/apache/incubator-netbeans/blob/master/o.apache.xml.resolver/external/resolver.patch
[2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17
Re: Heads up: Missing patches for external binary
Posted by Geertjan Wielenga <ge...@googlemail.com>.
SwingX is not part of NetBeans and definitely not part of the donation from
Oracle to Apache.
Gj
On Sat, 21 Oct 2017 at 23:27, David Bolsover <da...@bolsover.com> wrote:
> Would the same be true for the SwingX library? - this is copyright Sun
> micro but is licensed Gnu lesser.
>
> Regards David
> David Bolsover
> E:david@bolsover.com
> T:01298813828
> M:07773428118
>
> -----Original Message-----
> From: Geertjan Wielenga [geertjan.wielenga@googlemail.com]
> Received: Saturday, 21 Oct 2017, 10:35
> To: dev@netbeans.incubator.apache.org [dev@netbeans.incubator.apache.org]
> Subject: Re: Heads up: Missing patches for external binary
>
> Yes, if created by a Sun or Oracle employee, it belonged to Sun or Oracle
> and now to Apache.
>
> Gj
>
> On Sat, Oct 21, 2017 at 11:13 AM, Antonio <an...@vieiro.net> wrote:
>
> > Hi again,
> >
> > The question is exactly what the license for these are. Should we
> consider
> > this is Apache 2.0 licensed? After all this was coming from an Oracle
> > employee (2009, after Sun merge), right?
> >
> > See the attachments of this email for the decompiled sources (as
> > decompiled with [1]).
> >
> > Cheers,
> > Antonio
> >
> > [1] http://jd.benow.ca/
> >
> >
> > On 21/10/17 11:02, Emilian Bold wrote:
> >
> >> Nice detective work!
> >>
> >> You could try to decompile those two classes and see what they are all
> >> about. Not sure how we should treat the license for these: Apache 2.0?
> >>
> >> Another approach would be to go back to the drawing board, see why we
> >> needed those patches in the 1st place and see if we can't make it work
> >> with a current-day xml-resolver. Maybe try and push the fix upstream,
> >> being another Apache project and all...
> >>
> >> Perhaps somebody from NetBeans will find the missing code, it's odd
> >> they are gone but also not entirely unexpected as these external
> >> binaries were not automatically generated, but manually...
> >>
> >> --emi
> >>
> >>
> >> On Sat, Oct 21, 2017 at 11:34 AM, Antonio <an...@vieiro.net> wrote:
> >>
> >>> Hi all,
> >>>
> >>> I'm trying to build the external binary for the o.apache.xml.resolver
> >>> module.
> >>>
> >>> - Problem:
> >>>
> >>> This module has a patch file [1] that works against
> xml-commons/resolver
> >>> version 1.1 (2003)
> >>>
> >>> In 2009 (see [2]) "a new method was added to
> >>> org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version
> >>> 1.2. I
> >>> do have a patch for that, no worries here.
> >>>
> >>> But also "two new classes
> org.apache.xml.resolver.NbCatalogManager.java"
> >>> and
> >>> "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to
> the
> >>> external binary ([2]).
> >>>
> >>> And I'm afraid these are gone forever. There's no patch for those and
> >>> they're not kept in the NetBeans repository.
> >>>
> >>> - Proposed solution:
> >>>
> >>> I think I should try to decompile and recover those sources from the
> >>> existing binary kept in NetBeans hg repositories and build a patch for
> >>> those
> >>> new sources.
> >>>
> >>> - Questions:
> >>>
> >>> a) This is OK for you, right?
> >>> b) I assume nobody has the source code for
> >>> org.apache.xml.resolver.NbCatalogManager nor
> >>> org.apache.xml.resolver.NbCatalogResolver somewhere, right?
> >>>
> >>> Thanks,
> >>> Antonio
> >>>
> >>>
> >>> [1]
> >>> https://github.com/apache/incubator-netbeans/blob/master/o.
> >>> apache.xml.resolver/external/resolver.patch
> >>>
> >>> [2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17
> >>>
> >>
>
RE: Heads up: Missing patches for external binary
Posted by David Bolsover <da...@Bolsover.com>.
Would the same be true for the SwingX library? - this is copyright Sun micro but is licensed Gnu lesser.
Regards David
David Bolsover
E:david@bolsover.com
T:01298813828
M:07773428118
-----Original Message-----
From: Geertjan Wielenga [geertjan.wielenga@googlemail.com]
Received: Saturday, 21 Oct 2017, 10:35
To: dev@netbeans.incubator.apache.org [dev@netbeans.incubator.apache.org]
Subject: Re: Heads up: Missing patches for external binary
Yes, if created by a Sun or Oracle employee, it belonged to Sun or Oracle
and now to Apache.
Gj
On Sat, Oct 21, 2017 at 11:13 AM, Antonio <an...@vieiro.net> wrote:
> Hi again,
>
> The question is exactly what the license for these are. Should we consider
> this is Apache 2.0 licensed? After all this was coming from an Oracle
> employee (2009, after Sun merge), right?
>
> See the attachments of this email for the decompiled sources (as
> decompiled with [1]).
>
> Cheers,
> Antonio
>
> [1] http://jd.benow.ca/
>
>
> On 21/10/17 11:02, Emilian Bold wrote:
>
>> Nice detective work!
>>
>> You could try to decompile those two classes and see what they are all
>> about. Not sure how we should treat the license for these: Apache 2.0?
>>
>> Another approach would be to go back to the drawing board, see why we
>> needed those patches in the 1st place and see if we can't make it work
>> with a current-day xml-resolver. Maybe try and push the fix upstream,
>> being another Apache project and all...
>>
>> Perhaps somebody from NetBeans will find the missing code, it's odd
>> they are gone but also not entirely unexpected as these external
>> binaries were not automatically generated, but manually...
>>
>> --emi
>>
>>
>> On Sat, Oct 21, 2017 at 11:34 AM, Antonio <an...@vieiro.net> wrote:
>>
>>> Hi all,
>>>
>>> I'm trying to build the external binary for the o.apache.xml.resolver
>>> module.
>>>
>>> - Problem:
>>>
>>> This module has a patch file [1] that works against xml-commons/resolver
>>> version 1.1 (2003)
>>>
>>> In 2009 (see [2]) "a new method was added to
>>> org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version
>>> 1.2. I
>>> do have a patch for that, no worries here.
>>>
>>> But also "two new classes org.apache.xml.resolver.NbCatalogManager.java"
>>> and
>>> "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to the
>>> external binary ([2]).
>>>
>>> And I'm afraid these are gone forever. There's no patch for those and
>>> they're not kept in the NetBeans repository.
>>>
>>> - Proposed solution:
>>>
>>> I think I should try to decompile and recover those sources from the
>>> existing binary kept in NetBeans hg repositories and build a patch for
>>> those
>>> new sources.
>>>
>>> - Questions:
>>>
>>> a) This is OK for you, right?
>>> b) I assume nobody has the source code for
>>> org.apache.xml.resolver.NbCatalogManager nor
>>> org.apache.xml.resolver.NbCatalogResolver somewhere, right?
>>>
>>> Thanks,
>>> Antonio
>>>
>>>
>>> [1]
>>> https://github.com/apache/incubator-netbeans/blob/master/o.
>>> apache.xml.resolver/external/resolver.patch
>>>
>>> [2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17
>>>
>>
Re: Heads up: Missing patches for external binary
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Yes, if created by a Sun or Oracle employee, it belonged to Sun or Oracle
and now to Apache.
Gj
On Sat, Oct 21, 2017 at 11:13 AM, Antonio <an...@vieiro.net> wrote:
> Hi again,
>
> The question is exactly what the license for these are. Should we consider
> this is Apache 2.0 licensed? After all this was coming from an Oracle
> employee (2009, after Sun merge), right?
>
> See the attachments of this email for the decompiled sources (as
> decompiled with [1]).
>
> Cheers,
> Antonio
>
> [1] http://jd.benow.ca/
>
>
> On 21/10/17 11:02, Emilian Bold wrote:
>
>> Nice detective work!
>>
>> You could try to decompile those two classes and see what they are all
>> about. Not sure how we should treat the license for these: Apache 2.0?
>>
>> Another approach would be to go back to the drawing board, see why we
>> needed those patches in the 1st place and see if we can't make it work
>> with a current-day xml-resolver. Maybe try and push the fix upstream,
>> being another Apache project and all...
>>
>> Perhaps somebody from NetBeans will find the missing code, it's odd
>> they are gone but also not entirely unexpected as these external
>> binaries were not automatically generated, but manually...
>>
>> --emi
>>
>>
>> On Sat, Oct 21, 2017 at 11:34 AM, Antonio <an...@vieiro.net> wrote:
>>
>>> Hi all,
>>>
>>> I'm trying to build the external binary for the o.apache.xml.resolver
>>> module.
>>>
>>> - Problem:
>>>
>>> This module has a patch file [1] that works against xml-commons/resolver
>>> version 1.1 (2003)
>>>
>>> In 2009 (see [2]) "a new method was added to
>>> org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version
>>> 1.2. I
>>> do have a patch for that, no worries here.
>>>
>>> But also "two new classes org.apache.xml.resolver.NbCatalogManager.java"
>>> and
>>> "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to the
>>> external binary ([2]).
>>>
>>> And I'm afraid these are gone forever. There's no patch for those and
>>> they're not kept in the NetBeans repository.
>>>
>>> - Proposed solution:
>>>
>>> I think I should try to decompile and recover those sources from the
>>> existing binary kept in NetBeans hg repositories and build a patch for
>>> those
>>> new sources.
>>>
>>> - Questions:
>>>
>>> a) This is OK for you, right?
>>> b) I assume nobody has the source code for
>>> org.apache.xml.resolver.NbCatalogManager nor
>>> org.apache.xml.resolver.NbCatalogResolver somewhere, right?
>>>
>>> Thanks,
>>> Antonio
>>>
>>>
>>> [1]
>>> https://github.com/apache/incubator-netbeans/blob/master/o.
>>> apache.xml.resolver/external/resolver.patch
>>>
>>> [2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17
>>>
>>
Re: Heads up: Missing patches for external binary
Posted by Antonio <an...@vieiro.net>.
Hi again,
The question is exactly what the license for these are. Should we
consider this is Apache 2.0 licensed? After all this was coming from an
Oracle employee (2009, after Sun merge), right?
See the attachments of this email for the decompiled sources (as
decompiled with [1]).
Cheers,
Antonio
[1] http://jd.benow.ca/
On 21/10/17 11:02, Emilian Bold wrote:
> Nice detective work!
>
> You could try to decompile those two classes and see what they are all
> about. Not sure how we should treat the license for these: Apache 2.0?
>
> Another approach would be to go back to the drawing board, see why we
> needed those patches in the 1st place and see if we can't make it work
> with a current-day xml-resolver. Maybe try and push the fix upstream,
> being another Apache project and all...
>
> Perhaps somebody from NetBeans will find the missing code, it's odd
> they are gone but also not entirely unexpected as these external
> binaries were not automatically generated, but manually...
>
> --emi
>
>
> On Sat, Oct 21, 2017 at 11:34 AM, Antonio <an...@vieiro.net> wrote:
>> Hi all,
>>
>> I'm trying to build the external binary for the o.apache.xml.resolver
>> module.
>>
>> - Problem:
>>
>> This module has a patch file [1] that works against xml-commons/resolver
>> version 1.1 (2003)
>>
>> In 2009 (see [2]) "a new method was added to
>> org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version 1.2. I
>> do have a patch for that, no worries here.
>>
>> But also "two new classes org.apache.xml.resolver.NbCatalogManager.java" and
>> "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to the
>> external binary ([2]).
>>
>> And I'm afraid these are gone forever. There's no patch for those and
>> they're not kept in the NetBeans repository.
>>
>> - Proposed solution:
>>
>> I think I should try to decompile and recover those sources from the
>> existing binary kept in NetBeans hg repositories and build a patch for those
>> new sources.
>>
>> - Questions:
>>
>> a) This is OK for you, right?
>> b) I assume nobody has the source code for
>> org.apache.xml.resolver.NbCatalogManager nor
>> org.apache.xml.resolver.NbCatalogResolver somewhere, right?
>>
>> Thanks,
>> Antonio
>>
>>
>> [1]
>> https://github.com/apache/incubator-netbeans/blob/master/o.apache.xml.resolver/external/resolver.patch
>>
>> [2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17
Re: Heads up: Missing patches for external binary
Posted by Emilian Bold <em...@gmail.com>.
Nice detective work!
You could try to decompile those two classes and see what they are all
about. Not sure how we should treat the license for these: Apache 2.0?
Another approach would be to go back to the drawing board, see why we
needed those patches in the 1st place and see if we can't make it work
with a current-day xml-resolver. Maybe try and push the fix upstream,
being another Apache project and all...
Perhaps somebody from NetBeans will find the missing code, it's odd
they are gone but also not entirely unexpected as these external
binaries were not automatically generated, but manually...
--emi
On Sat, Oct 21, 2017 at 11:34 AM, Antonio <an...@vieiro.net> wrote:
> Hi all,
>
> I'm trying to build the external binary for the o.apache.xml.resolver
> module.
>
> - Problem:
>
> This module has a patch file [1] that works against xml-commons/resolver
> version 1.1 (2003)
>
> In 2009 (see [2]) "a new method was added to
> org.apache.xml.resolver.Catalog.java" to xml-commons/resolver version 1.2. I
> do have a patch for that, no worries here.
>
> But also "two new classes org.apache.xml.resolver.NbCatalogManager.java" and
> "org.apache.xml.resolver.tools.NbCatalogResolver.java" were added to the
> external binary ([2]).
>
> And I'm afraid these are gone forever. There's no patch for those and
> they're not kept in the NetBeans repository.
>
> - Proposed solution:
>
> I think I should try to decompile and recover those sources from the
> existing binary kept in NetBeans hg repositories and build a patch for those
> new sources.
>
> - Questions:
>
> a) This is OK for you, right?
> b) I assume nobody has the source code for
> org.apache.xml.resolver.NbCatalogManager nor
> org.apache.xml.resolver.NbCatalogResolver somewhere, right?
>
> Thanks,
> Antonio
>
>
> [1]
> https://github.com/apache/incubator-netbeans/blob/master/o.apache.xml.resolver/external/resolver.patch
>
> [2] https://netbeans.org/bugzilla/show_bug.cgi?id=128678#c17