Re: svn commit: r1072519 - in /subversion/trunk: ./ subversion/include/svn_io.h subversion/libsvn_subr/stream.c subversion/libsvn_subr/subst.c subversion/tests/libsvn_subr/stream-test.c

[Greg Stein <gs...@gmail.com>]

On Sun, Feb 20, 2011 at 02:05,  <st...@apache.org> wrote:
> Author: stefan2
> Date: Sun Feb 20 07:05:56 2011
> New Revision: 1072519
>
> URL: http://svn.apache.org/viewvc?rev=1072519&view=rev
> Log:
> Merge all changes (r1068695 - r1072516) from the
> integrate-stream-api-extensions.
>
> These patches add svn_stream_skip(), svn_stream_buffered()
> and svn_stream_supports_mark().

I don't see any users of these three functions. What are they intended
for? Some future patch? And if that patch is NOT going to land for
1.7, could we back these functions out until they are needed?

I'm very hesitant to continue expanding our stream concept. It used to
be a very simple read/write thing, but has grown into a much more
complex beast. I fear that we're making things more complex than they
need to be, rather than finding simpler solutions.

Thanks,
-g