You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2016/10/13 16:56:29 UTC

tinkerpop git commit: going to simply remove GroovyPeerPressureTest as it randomly fails in Groovy due to an id comparison that is sometimes one way and some times another (depending on threads). With Java, that problem doesn't happen. This is the safest

Repository: tinkerpop
Updated Branches:
  refs/heads/master b7cf48e65 -> d13ed72b4


going to simply remove GroovyPeerPressureTest as it randomly fails in Groovy due to an id comparison that is sometimes one way and some times another (depending on threads). With Java, that problem doesn't happen. This is the safest route as changing the test to be general will simply ruin its ability to ensure clusters and their size and the semantics of PeerPressure. FIXED #TINKERPOP-1466.


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/d13ed72b
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/d13ed72b
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/d13ed72b

Branch: refs/heads/master
Commit: d13ed72b45e95d120da97efbca397376165c6046
Parents: b7cf48e
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Thu Oct 13 10:45:19 2016 -0600
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Thu Oct 13 10:56:23 2016 -0600

----------------------------------------------------------------------
 .../tinkerpop/gremlin/process/GroovyProcessComputerSuite.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/d13ed72b/gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/process/GroovyProcessComputerSuite.java
----------------------------------------------------------------------
diff --git a/gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/process/GroovyProcessComputerSuite.java b/gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/process/GroovyProcessComputerSuite.java
index e411c1e..f3918b6 100644
--- a/gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/process/GroovyProcessComputerSuite.java
+++ b/gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/process/GroovyProcessComputerSuite.java
@@ -148,7 +148,7 @@ public class GroovyProcessComputerSuite extends ProcessComputerSuite {
             GroovyOrderTest.Traversals.class,
             GroovyPageRankTest.Traversals.class,
             GroovyPathTest.Traversals.class,
-            GroovyPeerPressureTest.Traversals.class,
+            // GroovyPeerPressureTest.Traversals.class, (ordering of ids in multi-threaded environments is non-deterministic)
             GroovyProfileTest.Traversals.class,
             GroovyProjectTest.Traversals.class,
             GroovyProgramTest.Traversals.class,