You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/08/14 17:39:24 UTC
[GitHub] [curator] TisonKun opened a new pull request #371: Add tison as Committer and PMC
TisonKun opened a new pull request #371:
URL: https://github.com/apache/curator/pull/371
cc @Randgalt @eolivelli I can see some of our commits merge without merge commits while others with. Thus I'm not sure what it the method I should put this commit onto master branch. Open a pull request for your advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli merged pull request #371: Add tison as Committer and PMC
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #371:
URL: https://github.com/apache/curator/pull/371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun commented on pull request #371: Add tison as Committer and PMC
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #371:
URL: https://github.com/apache/curator/pull/371#issuecomment-674186365
BTW, I've build the website locally and verify the change manually. From the guide it requires a version bump but it is necessary for website rebuild?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun commented on pull request #371: Add tison as Committer and PMC
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #371:
URL: https://github.com/apache/curator/pull/371#issuecomment-674314602
@eolivelli thanks for your advice! I think I've made the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #371: Add tison as Committer and PMC
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #371:
URL: https://github.com/apache/curator/pull/371#issuecomment-674201267
@TisonKun I have merged this patch using gitHub button.
We do not have a "standard" rule about commits, it is better IMO to squash the commits into one single commit in order to have a good history.
Regarding the website:
I got into the same problem while adding myself.
Probably the best thing is to push the website with the current -SNAPSHOT version.
IIRC I have cherry picked the commit to a temporary local branch started from the latest released tag and then I rebuild the website,
then I dropped the temporary branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org