[GitHub] [incubator-dubbo] wangnimaa opened pull request #2573: NullPointerException

["wangnimaa (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

XXXXX

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] diecui1202 commented on issue #2573: NullPointerException

["diecui1202 (GitHub)" <gi...@apache.org>]

@wangnimaa pls. describe the PR more detailedly.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2573: NullPointerException

["carryxyh (GitHub)" <gi...@apache.org>]

@wangnimaa 
Hi, I think your pr is mainly optimized for a code format. Please modify the description of your pr to make it more in line with your original intentions.

@diecui1202 @htynkn 
I think this string is more standardized in the previous way, so I merged it in this pr and hope it is merged into the master. What do you think?
https://github.com/apache/incubator-dubbo/pull/2571

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang closed pull request #2573: NullPointerException

["zonghaishang (GitHub)" <gi...@apache.org>]

[ pull request closed by zonghaishang ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang commented on issue #2573: NullPointerException

["zonghaishang (GitHub)" <gi...@apache.org>]

java.lang.reflect.Method#getParameterTypes: 

```
Returns an array of {@code Parameter} objects that represent
all the parameters to the underlying executable represented by
this object.  Returns an array of length 0 if the executable
has no parameters.
```

No null pointer exception will thrown.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on pull request #2573: NullPointerException

["htynkn (GitHub)" <gi...@apache.org>]

my understanding is if pts[i] is not null. getName will not be null.

Could you explain more what's scenario will cause NullPointException?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2573 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org