You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/08/16 17:41:45 UTC

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................

IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.

This test scrapes the /catalog webpage for metrics. This can
occasionally run into a race condition when a table lock is
being held for functional*.* tables and the test tries to get
the metrics. This result in a failed assert for the metrics.
This change rewrites the test to create new tables with
unique_database fixture to avoid flakiness.

Also, seperated out an assert with AND into two different asserts
so it's easy to track which one failed.

Testing:
Ran multiple runs of this test locally while refreshing the table.

Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
---
M tests/webserver/test_web_pages.py
1 file changed, 41 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/14075/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>