You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/08 03:18:50 UTC

Review Request 35197: Threading Can Cause Aggregate Alerts To Have Duplicate Alert Entries With Different States

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35197/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-11775
    https://issues.apache.org/jira/browse/AMBARI-11775


Repository: ambari


Description
-------

STR:
- install Ambari 1.7 with default services on stack 2.0
- upgrade Ambari to version 2.0
- stop all
- start all

On alerts tab there are two statuses for some of the aggregate alerts. This seems to be a threading issue with asynchronous events fired for the aggregate alerts.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 4d2add1 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 41dd1d5 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertSummaryDTO.java f56875f 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 104ebef 
  ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35197/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Re: Review Request 35197: Threading Can Cause Aggregate Alerts To Have Duplicate Alert Entries With Different States

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35197/#review87005
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 8, 2015, 1:18 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35197/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 1:18 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11775
>     https://issues.apache.org/jira/browse/AMBARI-11775
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> - install Ambari 1.7 with default services on stack 2.0
> - upgrade Ambari to version 2.0
> - stop all
> - start all
> 
> On alerts tab there are two statuses for some of the aggregate alerts. This seems to be a threading issue with asynchronous events fired for the aggregate alerts.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java 4d2add1 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 41dd1d5 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertSummaryDTO.java f56875f 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 104ebef 
>   ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35197/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>