You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/09 17:18:20 UTC
[GitHub] [kafka] hachikuji opened a new pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8
hachikuji opened a new pull request #11010:
URL: https://github.com/apache/kafka/pull/11010
This patch bumps the default frame version for kraft records from 0 to 1. At the same time, we reset all records versions back to 0 and we enable flexible version support for `UnregisterBrokerRecord`, which was missed previously. Note that the frame version bump also affects the KIP-405 records since they are sharing `AbstractApiMessageSerde`. Since these records were not part of any previous releases, I did not see a problem with this.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11010:
URL: https://github.com/apache/kafka/pull/11010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #11010:
URL: https://github.com/apache/kafka/pull/11010#discussion_r667102835
##########
File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -17,50 +17,34 @@
package org.apache.kafka.controller;
-import java.util.Arrays;
Review comment:
Do we really need to move these imports from above to below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11010:
URL: https://github.com/apache/kafka/pull/11010#discussion_r667105114
##########
File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -17,50 +17,34 @@
package org.apache.kafka.controller;
-import java.util.Arrays;
Review comment:
I can revert it. I use the auto-import tool in Intellij which likes a specific order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org