You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/08 04:19:16 UTC
[GitHub] [apisix-java-plugin-runner] ericluoliu opened a new pull request, #180: fix: hot reloading not working when java plugin runner is started from different working directory
ericluoliu opened a new pull request, #180:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/180
___
### Bugfix
- Description: when user runs apisix-java-plugin-runner from a different working directory than the root project, the *userDir* variable is incorrect. For example, if user uses command
java -jar -DAPISIX_LISTEN_ADDRESS=unix:/tmp/runner.sock -DAPISIX_CONF_EXPIRE_TIME=3600 apisix-java-plugin-runner.jar
to start apisix from within the runner-starter/target/ directory, the working directory is different.
- How to fix? Instead of using the working directory, use the absolute path to the root of the project instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] ericluoliu commented on pull request #180: fix: hot reloading not working when java plugin runner is started from different working directory
Posted by GitBox <gi...@apache.org>.
ericluoliu commented on PR #180:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/180#issuecomment-1207648970
@tzssangglass would we need to rename the variables too? maybe change userDir to projectDir?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #180: fix: hot reloading not working when java plugin runner is started from different working directory
Posted by GitBox <gi...@apache.org>.
tzssangglass merged PR #180:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #180: fix: hot reloading not working when java plugin runner is started from different working directory
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #180:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/180#issuecomment-1208146867
> @tzssangglass would we need to rename the variables too? maybe change userDir to projectDir?
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org