[GitHub] [commons-io] garydgregory commented on pull request #124: [IO-676] Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #124:
URL: https://github.com/apache/commons-io/pull/124#issuecomment-669922844


   > > @Isira-Seneviratne @chtompki
   > > Here is another thought which I think will give us more bang for the buck:
   > > All of these `FileUtils` time comparison APIs should convert their input `File` object to a`Path` with `toPath()` and forward the calls to `PathUtils` which opens the feature to any backing NIO file system, not old school `File` objects.
   > 
   > That sounds like a good idea.
   > 
   > However, there's a potential issue in that those methods would become unusable on most versions of Android, since the `java.nio.file` package is only supported on Android Oreo and higher (admittedly, I'm not sure if any Android apps will need to make use of those methods, and it's possible that the package [will be made available](https://issuetracker.google.com/issues/154309654) to all versions of Android via [desugaring](https://developer.android.com/studio/write/java8-support-table)).
   > 
   > Other than that, sounds good to me :)
   
   Hi @Isira-Seneviratne 
   
   After playing around a bit, I think I will proceed with this PR as is and leave a refactoring for later.
   
   TBH, I had not considered Android. Would you have time to research if there is a way to build and test for Android on GitHub Actions and/or Travis-CI?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org