[GitHub] [airflow] mik-laj commented on a change in pull request #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5565: [AIRFLOW-4899] Fix get_dataset_list from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#discussion_r307965074
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1670,7 +1670,7 @@ def get_dataset(self, dataset_id, project_id=None):
 
         return dataset_resource
 
-    def get_datasets_list(self, project_id=None):
+    def get_datasets_list(self, project_id=None, max_results=None, all=False):
 
 Review comment:
   What do you think about adding the `@GoogleCloudBaseHook.fallback_to_default_project_id``decorator?` This will allow you to delete the repeating code, but also add validation - this field is required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services