You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chunhui shen (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 03:15:39 UTC
[jira] [Created] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
--------------------------------------------------------------------------------------------------------------
Key: HBASE-5165
URL: https://issues.apache.org/jira/browse/HBASE-5165
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.4
Reporter: chunhui shen
Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
1.Table has already be disabled.
2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
4.DeleteTableHandler set table enabled.
4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5165:
------------------------------
Status: Patch Available (was: Open)
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183167#comment-13183167 ]
Zhihong Yu commented on HBASE-5165:
-----------------------------------
As Stack said:
bq. now when a table is disabled, we now set a flag for the table in zk rather than do it individually on each region
@Chunhui:
Can you address the above in ServerShutdownHandler ?
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "ramkrishna.s.vasudevan (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183308#comment-13183308 ]
ramkrishna.s.vasudevan edited comment on HBASE-5165 at 1/10/12 3:04 PM:
------------------------------------------------------------------------
@Chunhui
I just now saw your issue. It is same as HBASE-5155. Can you see my comment in HBASE-5155. I propose to use the TableState.ENABLED. Currently i am working on a patch for it. Will upload it by tomorrow.
was (Author: ram_krish):
@Chunhui
I just now saw your issue. It is same as HBASE-5155. Can you see my comment in HBSE-5155. I propose to use the TableState.ENABLED. Currently i am working on a patch for it. Will upload it by tomorrow.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183167#comment-13183167 ]
Zhihong Yu edited comment on HBASE-5165 at 1/10/12 9:39 AM:
------------------------------------------------------------
As Stack said in HBASE-5155:
bq. now when a table is disabled, we now set a flag for the table in zk rather than do it individually on each region
@Chunhui:
Can you address the above in ServerShutdownHandler ?
was (Author: zhihyu@ebaysf.com):
As Stack said:
bq. now when a table is disabled, we now set a flag for the table in zk rather than do it individually on each region
@Chunhui:
Can you address the above in ServerShutdownHandler ?
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "chunhui shen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183181#comment-13183181 ]
chunhui shen commented on HBASE-5165:
-------------------------------------
I'm not clear why we need to set disabled flag for each region in zk.
It seems no help for the issue.(DeleteTableHandler will delete these nodes, and ServerShutdownHandler will assign region if nodes not exist)
We only need to synchronize DeleteTableHandler and ServerShutdownHandler, to ensure deleted region not assigned.
Since regions of disabled table will not be assigned and fixed up in current strategy, we only need to ensure that no regions in assigning queue before set table enabled
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237309#comment-13237309 ]
Hadoop QA commented on HBASE-5165:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510019/hbase-5165v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1287//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1287//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1287//console
This message is automatically generated.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183170#comment-13183170 ]
Hadoop QA commented on HBASE-5165:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510019/hbase-5165v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -151 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 79 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/714//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/714//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/714//console
This message is automatically generated.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "chunhui shen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183018#comment-13183018 ]
chunhui shen commented on HBASE-5165:
-------------------------------------
Oh, sorry, I have not seen it.
They are the same issue, I will watch HBASE-5155, please close this.
Thanks.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183017#comment-13183017 ]
Zhihong Yu commented on HBASE-5165:
-----------------------------------
This looks like HBASE-5155
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183026#comment-13183026 ]
Zhihong Yu commented on HBASE-5165:
-----------------------------------
@Chunhui:
Ram hasn't provided patch for HBASE-5155 yet.
We can start with your patch.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183308#comment-13183308 ]
ramkrishna.s.vasudevan commented on HBASE-5165:
-----------------------------------------------
@Chunhui
I just now saw your issue. It is same as HBASE-5155. Can you see my comment in HBSE-5155. I propose to use the TableState.ENABLED. Currently i am working on a patch for it. Will upload it by tomorrow.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "chunhui shen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5165:
--------------------------------
Attachment: hbase-5165v2.patch
Modify it as Ted's comment in 5165v2.patch.(DeleteTableHandler doesn't set table enabled until no ServerShutdownHanler)
Since fixupDaughters() will not be executed if table is disabled, I think patchv2 fix this issue including HBASE-5155
Waiting for better approach.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch, hbase-5165v2.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "chunhui shen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183065#comment-13183065 ]
chunhui shen commented on HBASE-5165:
-------------------------------------
@Ted
This patch doesn't solve the problem of fixUpDaughters() considered by HBASE-5155
So, I need to make a new approach.
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "chunhui shen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5165:
--------------------------------
Attachment: hbase-5165.patch
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5165) Concurrent processing of
DeleteTableHandler and ServerShutdownHandler may cause deleted region to
assign again
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183061#comment-13183061 ]
Zhihong Yu commented on HBASE-5165:
-----------------------------------
Patch looks interesting.
Have you verified that the patch fixes the problem ?
{code}
LOG.debug("Waiting on processing of deadserver or initiallizing of master, deadServersInProgress = "
{code}
The above log should be removed. At least, its frequency should be reduced.
{code}
if (masterServices.getServerManager().areDeadServersInProgress()
|| ((HMaster) server).isInitialized()) {
{code}
I think the above should be:
{code}
if (masterServices.getServerManager().areDeadServersInProgress()
|| !((HMaster) server).isInitialized()) {
{code}
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause deleted region to assign again
> --------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5165
> URL: https://issues.apache.org/jira/browse/HBASE-5165
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: chunhui shen
> Attachments: hbase-5165.patch
>
>
> Concurrent processing of DeleteTableHandler and ServerShutdownHandler may cause following situation
> 1.Table has already be disabled.
> 2.ServerShutdownHandler is doing MetaReader.getServerUserRegions.
> 3.When step2 is processing or is completed just now, DeleteTableHandler starts to delete region(Remove region from META and Delete region from FS)
> 4.DeleteTableHandler set table enabled.
> 4.ServerShutdownHandler is starting to assign region which is alread deleted by DeleteTableHandler.
> The result of above operations is producing an invalid record in .META. and can't be fixed by hbck
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira