You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by snowch <gi...@git.apache.org> on 2016/08/09 13:16:32 UTC
[GitHub] zeppelin pull request #1309: [ZEPPELIN-1314] dump out the R command in debug...
GitHub user snowch opened a pull request:
https://github.com/apache/zeppelin/pull/1309
[ZEPPELIN-1314] dump out the R command in debug mode
### What is this PR for?
When diagnosing issues executing R, it would be useful to view the command that is being run so that command can be manually executed and debugged.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1314
### How should this be tested?
N/A
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snowch/zeppelin patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1309
----
commit 4345b88bd95fe5ce945c881710dc911a3dba2084
Author: Chris Snow <ch...@gmail.com>
Date: 2016-08-09T13:11:45Z
dump out the R command in debug mode
dump out the R command to facilitate manually running it, e.g. for fault diagnosis purposes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1309: [ZEPPELIN-1314] dump out the R command in debug mode
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1309
@snowch Thanks for explanation. Make sense.
CI is failing with
```
[INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-fail-build) @ zeppelin-spark_2.11 ---
/home/travis/build/apache/zeppelin/spark/src/main/java/org/apache/zeppelin/spark/ZeppelinR.java:148:5: unexpected token: executor
[INFO]
[INFO] There are 1 checkstyle errors.
[ERROR] ZeppelinR.java[149:5] (extension) TreeWalker: Got an exception - expecting EOF, found 'outputStream'
```
Could you take a look and make CI green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1309: [ZEPPELIN-1314] dump out the R command in debug mode
Posted by snowch <gi...@git.apache.org>.
Github user snowch commented on the issue:
https://github.com/apache/zeppelin/pull/1309
The R process launched, but I received an error. I would like to be able to execute the R command manually which is why I want to dump out how R is being called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1309: [ZEPPELIN-1314] dump out the R command in debug mode
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1309
@snowch Not sure how much dumping out the R command would help diagnose. Do you meet any case that failed to launch the R process ? If you want to diagnose the R process after it is launched. You can refer SparkOutputStream which will print output in debug level. You just need add the following line in log4j.properties.
```
log4j.logger.org.apache.zeppelin.spark.SparkOutputStream=DEBUG
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1309: [ZEPPELIN-1314] dump out the R command in debug mode
Posted by snowch <gi...@git.apache.org>.
Github user snowch commented on the issue:
https://github.com/apache/zeppelin/pull/1309
Damn, I had deleted my forked repository. I've created a new PR here: https://github.com/apache/zeppelin/pull/1531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1309: [ZEPPELIN-1314] dump out the R command in debug...
Posted by snowch <gi...@git.apache.org>.
Github user snowch closed the pull request at:
https://github.com/apache/zeppelin/pull/1309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1309: [ZEPPELIN-1314] dump out the R command in debug mode
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1309
@snowch Sorry for the delay,
I'm actually not an R expert so I'm not sure what this change bring.
Could you maybe provide a paragraph code example or before/after screenshot example to understand a bit more?
Also you can probably rebase your branch to have a green CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---