You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/23 22:59:38 UTC
[kudu-CR] [integration-tests] WARN UNUSED RESULT for SetFlag()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7286
Change subject: [integration-tests] WARN_UNUSED_RESULT for SetFlag()
......................................................................
[integration-tests] WARN_UNUSED_RESULT for SetFlag()
Added WARN_UNUSED_RESULT specifier for ExternalMiniCluster::SetFlag()
method. Also, updated a few call sites to check the result of calling
the method.
Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
---
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/ts_recovery-itest.cc
3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/7286/1
--
To view, visit http://gerrit.cloudera.org:8080/7286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [integration-tests] WARN UNUSED RESULT for SetFlag()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [integration-tests] WARN_UNUSED_RESULT for SetFlag()
......................................................................
[integration-tests] WARN_UNUSED_RESULT for SetFlag()
Added WARN_UNUSED_RESULT specifier for ExternalMiniCluster::SetFlag()
method. Also, updated a few call sites to check the result of calling
the method.
Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Reviewed-on: http://gerrit.cloudera.org:8080/7286
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/ts_recovery-itest.cc
3 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [integration-tests] WARN UNUSED RESULT for SetFlag()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [integration-tests] WARN_UNUSED_RESULT for SetFlag()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [integration-tests] WARN UNUSED RESULT for SetFlag()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [integration-tests] WARN_UNUSED_RESULT for SetFlag()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [integration-tests] WARN UNUSED RESULT for SetFlag()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [integration-tests] WARN_UNUSED_RESULT for SetFlag()
......................................................................
Patch Set 2: Verified+1
Unrelated flake in kudu.tests.test_scantoken.TestScanToken.test_double_pred
--
To view, visit http://gerrit.cloudera.org:8080/7286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6684f054762e48a558db09ad03ab0f77053487e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No