You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/17 06:26:53 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call

sureshanaparti commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r595742398



##########
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##########
@@ -201,7 +202,8 @@ public boolean generateUsageRecords(GenerateUsageRecordsCmd cmd) {
         }
 
         boolean isAdmin = false;

Review comment:
       ```suggestion
           boolean isAdmin = _accountService.isRootAdmin(caller.getId());
   ```
   
   Similarly as the other vars for domain admin / user.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org