[jira] [Commented] (HELIX-740) ZkHelixAdmin:NPE

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HELIX-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547184#comment-16547184 ] 

ASF GitHub Bot commented on HELIX-740:
--------------------------------------

GitHub user zhan849 opened a pull request:

    https://github.com/apache/helix/pull/257

    [HELIX-740] check NPE in getInstancesInClusterWithTag and throw more meaningful exception

    Added cluster config check in `getInstancesInClusterWithTag()` and throw IllegalStateException when instance config is missing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/helix-admin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
    
----
commit f4bb7d60782150c7d713c907211cc9d41f002c48
Author: Harry Zhang <hr...@...>
Date:   2018-07-17T22:50:02Z

    [HELIX-740] check NPE in getInstancesInClusterWithTag and throw more meaningful exception

----


> ZkHelixAdmin:NPE
> ----------------
>
>                 Key: HELIX-740
>                 URL: https://issues.apache.org/jira/browse/HELIX-740
>             Project: Apache Helix
>          Issue Type: Task
>            Reporter: Hao Zhang
>            Priority: Major
>
> The NPE occurs in this line: [https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java#L669]
> Basically, we ended up in a situation where we had an instance whose config was deleted. The line above should handle this more gracefully;we need more meaningful error information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)