You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/09 12:46:47 UTC
[PR] test(provider): pin the consumer connection mapping [rocketmq-dashboard]
zjncs opened a new pull request, #5848:
URL: https://github.com/apache/rocketmq-dashboard/pull/5848
### What
`ConsumerConnections` maps a broker (or proxy) consumer connection set to the online instance view — the single source both the group listing and the group detail derive the online instances from. It had no test. This adds 3 tests.
### What is pinned
- **a null connection yields no instances**; a connection without a connection set yields no instances;
- **every connection becomes an instance carrying its client id and address**.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: the address mapped from the client id (red).
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(provider): pin the consumer connection mapping [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #5848: test(provider): pin the consumer connection mapping
URL: https://github.com/apache/rocketmq-dashboard/pull/5848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(provider): pin the consumer connection mapping [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #5848:
URL: https://github.com/apache/rocketmq-dashboard/pull/5848#issuecomment-6729171020
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org