You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/25 11:11:26 UTC
[GitHub] [airflow] Junnplus opened a new pull request #14454: lazy load stats logger instance
Junnplus opened a new pull request #14454:
URL: https://github.com/apache/airflow/pull/14454
closes: https://github.com/apache/airflow/issues/13741
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14454: Fix statsd metrics not sending when using daemon mode
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14454:
URL: https://github.com/apache/airflow/pull/14454#issuecomment-1020118932
> Hello we still see this problem in version 2.2.3 of Airflow. Can you please recheck at it?
This issue is closed. I tihnk this is another problem. Can you please create a new issue with all the logs and information on how your configuration is? It's likely configuration on your side, so opening a [discussion](https://github.com/apache/airflow/discussions) first, before it will be determined as Airflow issue is preferred (also a bit esier than creating an issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14454: Fix statsd metrics not sending when using daemon mode
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14454:
URL: https://github.com/apache/airflow/pull/14454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14454: lazy load stats logger instance
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14454:
URL: https://github.com/apache/airflow/pull/14454#discussion_r583684820
##########
File path: airflow/stats.py
##########
@@ -348,25 +348,28 @@ def timer(self, stat=None, *args, tags=None, **kwargs):
class _Stats(type):
+ factory = None
instance: Optional[StatsLogger] = None
def __getattr__(cls, name):
+ if not cls.instance:
+ try:
+ cls.instance = cls.factory()
+ except (socket.gaierror, ImportError) as e:
+ log.error("Could not configure StatsClient: %s, using DummyStatsLogger instead.", e)
Review comment:
If a stats backend _isn't_ configured, isn't factory going to be None, and so we'd die with a TypeError?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] saimon46 commented on pull request #14454: Fix statsd metrics not sending when using daemon mode
Posted by GitBox <gi...@apache.org>.
saimon46 commented on pull request #14454:
URL: https://github.com/apache/airflow/pull/14454#issuecomment-1020099430
Hello we still see this problem in version 2.2.3 of Airflow. Can you please recheck at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14454: lazy load stats logger instance
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14454:
URL: https://github.com/apache/airflow/pull/14454#discussion_r583686852
##########
File path: airflow/stats.py
##########
@@ -348,25 +348,28 @@ def timer(self, stat=None, *args, tags=None, **kwargs):
class _Stats(type):
+ factory = None
instance: Optional[StatsLogger] = None
def __getattr__(cls, name):
+ if not cls.instance:
+ try:
+ cls.instance = cls.factory()
+ except (socket.gaierror, ImportError) as e:
+ log.error("Could not configure StatsClient: %s, using DummyStatsLogger instead.", e)
Review comment:
Oh no, cos this is a metaclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14454: lazy load stats logger instance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14454:
URL: https://github.com/apache/airflow/pull/14454#issuecomment-786159220
[The Workflow run](https://github.com/apache/airflow/actions/runs/600571017) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org