[GitHub] [tvm] manupa-arm commented on a change in pull request #7686: [Texture support][Part 1] TIR lowering and OpenCL support

[GitBox <gi...@apache.org>]

manupa-arm commented on a change in pull request #7686:
URL: https://github.com/apache/tvm/pull/7686#discussion_r632398783



##########
File path: include/tvm/ir/type.h
##########
@@ -181,6 +181,55 @@ class PointerType : public Type {
   TVM_DEFINE_OBJECT_REF_METHODS(PointerType, Type, PointerTypeNode);
 };
 
+/*!
+ * \brief Low-level texture type.
+ *
+ *  TextureType represents type hints in the TIR to be
+ *  passed to the final code generator.
+ *
+ *  TextureType should not occur in the high-level analysis.
+ *
+ * \sa TextureType
+ */
+class TextureTypeNode : public TypeNode {
+ public:
+  /*!
+   * \brief The base type of the texture.
+   */

Review comment:
       @tqchen @csullivan , just curious (and for my understanding) why cant we point the Var to a buffer (using the buffer map) and buffer has a way to mention the scope ?
   
   Came here by looking at why this is needed in #8017 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org