[GitHub] [incubator-superset] bryanck commented on pull request #9777: Check for empty dataframes before processing

[GitBox <gi...@apache.org>]

bryanck commented on pull request #9777:
URL: https://github.com/apache/incubator-superset/pull/9777#issuecomment-629872341


   I did try handling it upstream first, checking before the `get_data` call in `BaseViz`, but some visualizations, such as FilterBox, didn't work with that approach, so I felt it was better to leave it in the viz handler function, at least for now in 0.36.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org