You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/08/18 11:30:13 UTC

[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #8107: IGNITE-13183 Query timeout redesign

tledkov-gridgain commented on a change in pull request #8107:
URL: https://github.com/apache/ignite/pull/8107#discussion_r472107934



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinStatement.java
##########
@@ -498,9 +501,7 @@ void closeOnDisconnect() {
         if (timeout < 0)
             throw new SQLException("Invalid timeout value.");
 
-        this.timeout = timeout * 1000;
-
-        reqTimeout = this.timeout;
+        timeout(timeout * 1000 > timeout ? timeout * 1000 : Integer.MAX_VALUE);

Review comment:
       Sure, the one line above it was checked.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org