You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/04/15 07:04:50 UTC

[GitHub] [incubator-eventmesh] li-xiao-shuang opened a new issue, #834: [Feature] Support nacos registry

li-xiao-shuang opened a new issue, #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Feature Request
   
   Provide service registry discovery capability of NACOS for EventMesh
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1109423193

   Since this the eventmesh has supported regist to nacos, we can consider supporting the reporting of data to the registry for some other features such as #827 @li-xiao-shuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] li-xiao-shuang commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1100119115

   > We also need to consider whether the DEFINITION of the API layer meets the existing requirements, the reporting information interacted with the registry must ensure a certain scalability.
   
   nacos should be satisfied at present


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] li-xiao-shuang commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1110639157

   > Since the eventmesh has supported regist to nacos, we can consider supporting the reporting of data to the registry for some other features such as #827 @li-xiao-shuang
   
   What data do I need to register with NACOS?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen closed issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
qqeasonchen closed issue #834: [Feature] Support nacos registry
URL: https://github.com/apache/incubator-eventmesh/issues/834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] li-xiao-shuang commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1099985343

   ![](https://tva1.sinaimg.cn/large/e6c9d24ely1h1aikhu7mrj21260u00ub.jpg)
   
   ### Support nacos registry implementation:
   - Implement the RegistryService interface in spi mode
   - Added registry service address configuration items, for example: 
      `eventMesh.registry.address=127.0.0.1:8848`
   - Load the specified registry type in the init method
   - Perform service registration, heartbeat maintenance, etc. in the start mode
   - Service logout and resource shutdown in shutdown method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1100007715

   We also need to consider whether the DEFINITION of the API layer meets the existing requirements, the reporting information interacted with the registry must ensure a certain scalability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1100003860

   It is better to control the lifecycle of `RegistryService` in `EventMeshServer`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] li-xiao-shuang commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
li-xiao-shuang commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1100006097

   > It is better to control the lifecycle of `RegistryService` in `EventMeshServer`.
   
   Yes, that's it for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on issue #834: [Feature] Support nacos registry

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #834:
URL: https://github.com/apache/incubator-eventmesh/issues/834#issuecomment-1110646778

   > 
   
   webhook feature is undering detailed design, after the design we may know what data structrue will be registed to NACOS, you can keep track of this #827 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org