You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 16:09:00 UTC

[GitHub] [superset] zhaoyongjie commented on a change in pull request #15740: feat(explore): UX improvements for drag'n'dropping time column

zhaoyongjie commented on a change in pull request #15740:
URL: https://github.com/apache/superset/pull/15740#discussion_r671370112



##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -119,7 +119,23 @@ export default function DataSourcePanel({
   controls: { datasource: datasourceControl },
   actions,
 }: Props) {
-  const { columns, metrics } = datasource;
+  const { columns: _columns, metrics } = datasource;
+
+  // display temporal column first
+  const columns = useMemo(
+    () =>

Review comment:
       Is this by design?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org