You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by markflyhigh <gi...@git.apache.org> on 2017/01/17 20:02:24 UTC
[GitHub] beam pull request #1784: Fix Incorrect Value Parsing in Test Pipeline Test
GitHub user markflyhigh opened a pull request:
https://github.com/apache/beam/pull/1784
Fix Incorrect Value Parsing in Test Pipeline Test
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Use `split('=')[1]` to parse value from a key-value string (using `=` as separator) have a potential problem.
In `test_append_verifier_in_extra_opt`, the value is a pickled string and contains more than one `=`, we should stop parsing at the first `=` to get correct value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam fix-test-pipeline-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1784
----
commit 8cb8a10d14d4994de55683adc3361012dd793c15
Author: Mark Liu <ma...@google.com>
Date: 2017-01-17T19:54:02Z
Fix Incorrect Split in Test Pipeline Test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #1784: [BEAM-1188] Fix Incorrect Value Parsing in Test Pip...
Posted by markflyhigh <gi...@git.apache.org>.
Github user markflyhigh closed the pull request at:
https://github.com/apache/beam/pull/1784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #1784: [BEAM-1188] Fix Incorrect Value Parsing in Test Pip...
Posted by markflyhigh <gi...@git.apache.org>.
GitHub user markflyhigh reopened a pull request:
https://github.com/apache/beam/pull/1784
[BEAM-1188] Fix Incorrect Value Parsing in Test Pipeline Test
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Use `split('=')[1]` to parse value from a key-value string (using `=` as separator) have a potential problem.
In `test_append_verifier_in_extra_opt`, the value is a pickled string and contains more than one `=`, we should stop parsing at the first `=` to get correct value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam fix-test-pipeline-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1784
----
commit 8cb8a10d14d4994de55683adc3361012dd793c15
Author: Mark Liu <ma...@google.com>
Date: 2017-01-17T19:54:02Z
Fix Incorrect Split in Test Pipeline Test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #1784: [BEAM-1188] Fix Incorrect Value Parsing in Test Pip...
Posted by markflyhigh <gi...@git.apache.org>.
Github user markflyhigh closed the pull request at:
https://github.com/apache/beam/pull/1784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---