You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/24 19:31:48 UTC

[GitHub] andrewfayres commented on a change in pull request #12955: [MXNET-1159]Added unit tests for making Resource Scope work in Java

andrewfayres commented on a change in pull request #12955: [MXNET-1159]Added unit tests for making Resource Scope work in Java
URL: https://github.com/apache/incubator-mxnet/pull/12955#discussion_r227930062
 
 

 ##########
 File path: scala-package/pom.xml
 ##########
 @@ -190,8 +190,8 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>3.3</version>
         <configuration>
-          <source>1.6</source>
-          <target>1.6</target>
+          <source>1.8</source>
 
 Review comment:
   Maybe I'm overlooking it but I don't see anything that we need Java 8 for. Try with resources was introduced in Java 7. The three lambda's that I see could easily be for loops.
   
   I've got no issue with the idea of us moving to 8 and starting that discussion on the dev list. In the meantime I think we could move to 7 and rewrite the few lambdas.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services