You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2018/09/14 21:00:28 UTC

[mesos] 02/02: Eliminating an unnecessary copy when devolving a scheduler call.

This is an automated email from the ASF dual-hosted git repository.

bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit 97fb46d32153df056bc903c1f320cf113618943d
Author: Benjamin Mahler <bm...@apache.org>
AuthorDate: Tue Sep 11 17:55:09 2018 -0700

    Eliminating an unnecessary copy when devolving a scheduler call.
    
    Review: https://reviews.apache.org/r/68696
---
 src/internal/devolve.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/internal/devolve.cpp b/src/internal/devolve.cpp
index a5d9ab9..491ed2a 100644
--- a/src/internal/devolve.cpp
+++ b/src/internal/devolve.cpp
@@ -216,8 +216,8 @@ scheduler::Call devolve(const v1::scheduler::Call& call)
   if (call.type() == v1::scheduler::Call::ACKNOWLEDGE_OPERATION_STATUS &&
       call.has_acknowledge_operation_status() &&
       call.acknowledge_operation_status().has_agent_id()) {
-    _call.mutable_acknowledge_operation_status()->mutable_slave_id()
-      ->CopyFrom(devolve(call.acknowledge_operation_status().agent_id()));
+    *_call.mutable_acknowledge_operation_status()->mutable_slave_id() =
+      devolve(call.acknowledge_operation_status().agent_id());
   }
 
   return _call;