[GitHub] [arrow-rs] askoa commented on a diff in pull request #3411: refactor: convert `*like_dyn`, `*like_utf8_scalar_dyn` and `*like_dict` functions to macros

[GitBox <gi...@apache.org>]

askoa commented on code in PR #3411:
URL: https://github.com/apache/arrow-rs/pull/3411#discussion_r1059780455


##########
arrow-string/src/like.rs:
##########
@@ -25,6 +25,53 @@ use arrow_select::take::take;
 use regex::Regex;
 use std::collections::HashMap;
 
+macro_rules! dyn_function {
+    ($sql:tt, $fn_name:tt, $fn_utf8:tt, $fn_dict:tt) => {
+#[doc = concat!("Perform SQL `left ", $sql ," right` operation on [`StringArray`] /")]
+/// [`LargeStringArray`], or [`DictionaryArray`] with values
+/// [`StringArray`]/[`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.

Review Comment:
   I changed the documentation back to `like_utf8` as I realized it is on purpose. The current code points to `like_utf8` in all functions as its the only function with an example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org