You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/04 07:13:50 UTC
[GitHub] [iceberg] kbendick opened a new issue #1292: [ErrorProne] Fix outstanding error prone warnings of type ByteBufferBackingArray
kbendick opened a new issue #1292:
URL: https://github.com/apache/iceberg/issues/1292
```
/Users/kbendick/repos/iceberg/spark/src/main/java/org/apache/iceberg/spark/data/SparkValueReaders.java:140: warning: [ByteBufferBackingArray] ByteBuffer.array() shouldn't be called unless ByteBuffer.arrayOffset() is used or if the ByteBuffer was initialized using ByteBuffer.wrap() or ByteBuffer.allocate().
decoder.readFixed(buffer.array(), 0, 16);
^
(see https://errorprone.info/bugpattern/ByteBufferBackingArray)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick closed issue #1292: [ErrorProne] Fix outstanding error prone warnings of type ByteBufferBackingArray
Posted by GitBox <gi...@apache.org>.
kbendick closed issue #1292:
URL: https://github.com/apache/iceberg/issues/1292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1292: [ErrorProne] Fix outstanding error prone warnings of type ByteBufferBackingArray
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1292:
URL: https://github.com/apache/iceberg/issues/1292#issuecomment-699692610
Oops forgot to close this but this has been handled and it does not appear that there are any `ByteBufferBackingArray` errors in the current master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1292: [ErrorProne] Fix outstanding error prone warnings of type ByteBufferBackingArray
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1292:
URL: https://github.com/apache/iceberg/issues/1292#issuecomment-668425995
I can submit a patch for this by end of the week. I'm using these fixes to further familiarize myself with the code base as I work my way up to making non-trivial commits 😉 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org