You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openwebbeans.apache.org by "Eric Covener (JIRA)" <ji...@apache.org> on 2010/01/15 02:58:54 UTC

[jira] Created: (OWB-231) exception using abstract decorators

exception using abstract decorators
-----------------------------------

                 Key: OWB-231
                 URL: https://issues.apache.org/jira/browse/OWB-231
             Project: OpenWebBeans
          Issue Type: Bug
          Components: Interceptor and Decorators
    Affects Versions: M3
            Reporter: Eric Covener
            Assignee: Gurkan Erdogdu
             Fix For: M4


After r897450, abstract decorator classes are passed to Constructor.newInstance() and cause an exception:

Caused by: java.lang.InstantiationException
	at sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:30)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:515)
	at org.apache.webbeans.inject.InjectableConstructor.doInjection(InjectableConstructor.java:87)
	at org.apache.webbeans.component.ManagedBean.createComponentInstance(ManagedBean.java:61)
	at org.apache.webbeans.component.AbstractInjectionTargetBean.createDefaultInstance(AbstractInjectionTargetBean.java:128)
	at org.apache.webbeans.component.AbstractInjectionTargetBean.createInstance(AbstractInjectionTargetBean.java:112)
	at org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
	at org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:66)
	at org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:150)
	at org.apache.webbeans.decorator.WebBeansDecorator.createInstance(WebBeansDecorator.java:244)
	at org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
	... 33 more


If you take Joe Bergmark's testcase from OWB-151, and make the bean @RequestScoped and the decorator abstract, you can generate the same backtrace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (OWB-231) exception using abstract decorators

Posted by Gurkan Erdogdu <cg...@gmail.com>.

Spec. says that if Decorator class not @Dependent, unportable behavior
occurs. Also it says that @Dependent scoped beans does not require to define
default constructor.

But what occurs if Decorator is an abstract class? It must define default
parameter otherwise it can not be subclassed and instantiated?

Any comments?

Thanks;

--Gurkan

2010/1/15 Gurkan Erdogdu <cg...@gmail.com>

> I think that this is related with Decorator class has not a default
> constructor.
>
> What is your Decorator bean you are talking about? Does it contain default
> no param constructor?
>
> Thanks;
>
> --Gurkan
>
> 2010/1/15 Eric Covener (JIRA) <ji...@apache.org>
>
> exception using abstract decorators
>> -----------------------------------
>>
>>                 Key: OWB-231
>>                 URL: https://issues.apache.org/jira/browse/OWB-231
>>             Project: OpenWebBeans
>>          Issue Type: Bug
>>          Components: Interceptor and Decorators
>>    Affects Versions: M3
>>            Reporter: Eric Covener
>>            Assignee: Gurkan Erdogdu
>>             Fix For: M4
>>
>>
>> After r897450, abstract decorator classes are passed to
>> Constructor.newInstance() and cause an exception:
>>
>> Caused by: java.lang.InstantiationException
>>        at
>> sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:30)
>>        at java.lang.reflect.Constructor.newInstance(Constructor.java:515)
>>        at
>> org.apache.webbeans.inject.InjectableConstructor.doInjection(InjectableConstructor.java:87)
>>        at
>> org.apache.webbeans.component.ManagedBean.createComponentInstance(ManagedBean.java:61)
>>        at
>> org.apache.webbeans.component.AbstractInjectionTargetBean.createDefaultInstance(AbstractInjectionTargetBean.java:128)
>>        at
>> org.apache.webbeans.component.AbstractInjectionTargetBean.createInstance(AbstractInjectionTargetBean.java:112)
>>        at
>> org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
>>        at
>> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:66)
>>        at
>> org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:150)
>>        at
>> org.apache.webbeans.decorator.WebBeansDecorator.createInstance(WebBeansDecorator.java:244)
>>        at
>> org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
>>        ... 33 more
>>
>>
>> If you take Joe Bergmark's testcase from OWB-151, and make the bean
>> @RequestScoped and the decorator abstract, you can generate the same
>> backtrace.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
> --
> Gurkan Erdogdu
> http://gurkanerdogdu.blogspot.com
>



-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com

Re: [jira] Created: (OWB-231) exception using abstract decorators

Posted by Eric Covener <co...@gmail.com>.

On Fri, Jan 15, 2010 at 2:05 AM, Gurkan Erdogdu
<cg...@gmail.com> wrote:
> I think that this is related with Decorator class has not a default
> constructor.
>
> What is your Decorator bean you are talking about? Does it contain default
> no param constructor?

Adding the default no-param constructor did not change the symptom.
The decorator is the one from Joe's OWB-151 patch with some mods:

package org.apache.webbeans.newtests.decorators.dependent;

import javax.decorator.Decorator;
import javax.decorator.Delegate;
import javax.inject.Inject;

@Decorator
public abstract class NumberDecorator implements NumberProvider {
	
	public static boolean called = false;

	@Inject @Delegate NumberProvider np;
	
	public NumberDecorator() {
		super();
	}
	public int getANumber() {
		called = true;
		return np.getANumber();
	}
}

(constructor added, class changed to abstract, bean it decorates
changed to non-dependent for simplicity)

-- 
Eric Covener
covener@gmail.com

Re: [jira] Created: (OWB-231) exception using abstract decorators

Posted by Gurkan Erdogdu <cg...@gmail.com>.

I think that this is related with Decorator class has not a default
constructor.

What is your Decorator bean you are talking about? Does it contain default
no param constructor?

Thanks;

--Gurkan

2010/1/15 Eric Covener (JIRA) <ji...@apache.org>

> exception using abstract decorators
> -----------------------------------
>
>                 Key: OWB-231
>                 URL: https://issues.apache.org/jira/browse/OWB-231
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Interceptor and Decorators
>    Affects Versions: M3
>            Reporter: Eric Covener
>            Assignee: Gurkan Erdogdu
>             Fix For: M4
>
>
> After r897450, abstract decorator classes are passed to
> Constructor.newInstance() and cause an exception:
>
> Caused by: java.lang.InstantiationException
>        at
> sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:30)
>        at java.lang.reflect.Constructor.newInstance(Constructor.java:515)
>        at
> org.apache.webbeans.inject.InjectableConstructor.doInjection(InjectableConstructor.java:87)
>        at
> org.apache.webbeans.component.ManagedBean.createComponentInstance(ManagedBean.java:61)
>        at
> org.apache.webbeans.component.AbstractInjectionTargetBean.createDefaultInstance(AbstractInjectionTargetBean.java:128)
>        at
> org.apache.webbeans.component.AbstractInjectionTargetBean.createInstance(AbstractInjectionTargetBean.java:112)
>        at
> org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
>        at
> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:66)
>        at
> org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:150)
>        at
> org.apache.webbeans.decorator.WebBeansDecorator.createInstance(WebBeansDecorator.java:244)
>        at
> org.apache.webbeans.component.AbstractBean.create(AbstractBean.java:159)
>        ... 33 more
>
>
> If you take Joe Bergmark's testcase from OWB-151, and make the bean
> @RequestScoped and the decorator abstract, you can generate the same
> backtrace.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com