Re: [PR] Facilitate supervisor to update pending segment mapping in tasks (druid)

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #15039:
URL: https://github.com/apache/druid/pull/15039#discussion_r1349646113


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -1538,6 +1541,20 @@ public Response setEndOffsetsHTTP(
     return setEndOffsets(sequences, finish);
   }
 
+  @POST
+  @Path("updatePendingSegmentMapping")

Review Comment:
   ```suggestion
     @Path("pendingSegmentMapping")
   ```
   POST method implies update



##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClient.java:
##########
@@ -153,6 +155,12 @@ ListenableFuture<Boolean> setEndOffsetsAsync(
    */
   ListenableFuture<SeekableStreamIndexTaskRunner.Status> getStatusAsync(String id);
 
+  ListenableFuture<Boolean> updatePendingSegmentMapping(

Review Comment:
   javadocs please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org