You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/01/31 22:45:42 UTC
Review Request 56141: Add precheck for Auto-Start being disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
Bugs: AMBARI-19800
https://issues.apache.org/jira/browse/AMBARI-19800
Repository: ambari
Description
-------
A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/56141/diff/
Testing
-------
Manual. Automated pending
Thanks,
Nate Cole
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163806
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java (line 56)
<https://reviews.apache.org/r/56141/#comment235308>
something with line spacing
- Dmitro Lisnichenko
On Feb. 1, 2017, 4:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 4:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 1, 2017, 1:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > To make this robust against future changes, can we check with not equals instead?
Once the status becomes an enum, then yes.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163850
-----------------------------------------------------------
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163850
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java (line 67)
<https://reviews.apache.org/r/56141/#comment235334>
To make this robust against future changes, can we check with not equals instead?
- Alejandro Fernandez
On Feb. 1, 2017, 2:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 2:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163820
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 1, 2017, 1:08 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > ["AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
Are the other options valid / used? Why are they not enums - does that mean that people can somehow define their own on the fly?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 1, 2017, 1:08 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > ["AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
>
> Jonathan Hurley wrote:
> Are the other options valid / used? Why are they not enums - does that mean that people can somehow define their own on the fly?
>
> Nate Cole wrote:
> You told me AUTO_START was the only supported option. I won't make that change until we make start type an enum. String checking is bad.
>
> Nate Cole wrote:
> Sorry, you didn't, another engineer did. But my comment stands - until that's an enum, this will be the only check made in this class.
>
> Sandor Magyari wrote:
> Not sure if we are supporting these options yet officially, but I saw this in agent code, so agent is able to handle these, but it's true that there's no enum on server side.
This should stay a string until there's an enum - why isn't there an enum! :)
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 1, 2017, 1:08 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > ["AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
>
> Jonathan Hurley wrote:
> Are the other options valid / used? Why are they not enums - does that mean that people can somehow define their own on the fly?
You told me AUTO_START was the only supported option. I won't make that change until we make start type an enum. String checking is bad.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Sandor Magyari <sm...@hortonworks.com>.
> On Feb. 1, 2017, 6:08 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > ["AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
>
> Jonathan Hurley wrote:
> Are the other options valid / used? Why are they not enums - does that mean that people can somehow define their own on the fly?
>
> Nate Cole wrote:
> You told me AUTO_START was the only supported option. I won't make that change until we make start type an enum. String checking is bad.
>
> Nate Cole wrote:
> Sorry, you didn't, another engineer did. But my comment stands - until that's an enum, this will be the only check made in this class.
Not sure if we are supporting these options yet officially, but I saw this in agent code, so agent is able to handle these, but it's true that there's no enum on server side.
- Sandor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
On Feb. 1, 2017, 2:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 2:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 1, 2017, 1:08 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java, line 67
> > <https://reviews.apache.org/r/56141/diff/1/?file=1620601#file1620601line67>
> >
> > ["AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
>
> Jonathan Hurley wrote:
> Are the other options valid / used? Why are they not enums - does that mean that people can somehow define their own on the fly?
>
> Nate Cole wrote:
> You told me AUTO_START was the only supported option. I won't make that change until we make start type an enum. String checking is bad.
Sorry, you didn't, another engineer did. But my comment stands - until that's an enum, this will be the only check made in this class.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java (line 67)
<https://reviews.apache.org/r/56141/#comment235331>
["AUTO_INSTALL_START", "AUTO_START", "FULL"]
I think we may also check for other options as well.
- Sandor Magyari
On Feb. 1, 2017, 2:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 2:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163819
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java (lines 39 - 42)
<https://reviews.apache.org/r/56141/#comment235312>
Can these be private?
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java (line 67)
<https://reviews.apache.org/r/56141/#comment235313>
I think StringUtils has a safe equality method that let's you skip the empty/null check.
- Jonathan Hurley
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56141/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
>
>
> Bugs: AMBARI-19800
> https://issues.apache.org/jira/browse/AMBARI-19800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56141/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:57.215s
> [INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
> [INFO] Final Memory: 45M/694M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 56141: Add precheck for Auto-Start being disabled
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 9:32 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sandor Magyari.
Bugs: AMBARI-19800
https://issues.apache.org/jira/browse/AMBARI-19800
Repository: ambari
Description
-------
A new precheck is required to make sure that auto-start is disabled before starting an upgrade. This JIRA covers the backend requirements. The UI changes will be linked to this one.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java a204ada
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/56141/diff/
Testing (updated)
-------
Manual. Automated:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:57.215s
[INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
[INFO] Final Memory: 45M/694M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole