You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/26 01:06:32 UTC
[GitHub] [incubator-yunikorn-core] yangwwei opened a new pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
yangwwei opened a new pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179
This is needed by https://github.com/apache/incubator-yunikorn-k8shim/pull/140.
The shim side changes make sure the UUID is set per existing allocation, the core side needs to use the same UUID to track these recovered allocations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov-commenter commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649896571
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=h1) Report
> Merging [#179](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/e55b4048332f34d50fc1a028a7b8e76459fc42ee&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 59.91% 59.93% +0.01%
==========================================
Files 66 66
Lines 6404 6407 +3
==========================================
+ Hits 3837 3840 +3
Misses 2425 2425
Partials 142 142
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/partition\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BhcnRpdGlvbl9pbmZvLmdv) | `72.23% <100.00%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=footer). Last update [e55b404...5783eb4](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649912645
I just thought of a huge issue: if the shim has not passed in a UUID for the allocations we will lose track of the allocation.
If the `UUID == ""` it should fail. I added the changes on top of what you did and will commit when we pass the build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649920368
## Travis tests have failed
Hey @yangwwei,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
### 1st Build
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/jobs/702241754">View build log</a>
<details>
<summary>
<strong>
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
</strong>
</summary>
```
golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
```
</details>
<details>
<summary>
<strong>
make lint
</strong>
</summary>
```
running golangci-lint
pkg/cache/partition_info.go:555: unnecessary trailing newline (whitespace)
}
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1
```
</details>
###### TravisBuddy Request Identifier: c0cef300-b756-11ea-90cf-99978df78ba0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649894755
## Travis tests have failed
Hey @yangwwei,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
### 1st Build
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/jobs/702229634">View build log</a>
<details>
<summary>
<strong>
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
</strong>
</summary>
```
golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
```
</details>
<details>
<summary>
<strong>
make lint
</strong>
</summary>
```
running golangci-lint
pkg/cache/partition_info_test.go:514: File is not `gofmt`-ed with `-s` (gofmt)
AllocationKey: allocationUUID1,
AllocationTags: map[string]string{"a": "b"},
UUID: allocationUUID1,
ResourcePerAlloc: alloc1Res,
Priority: nil,
QueueName: queueName,
NodeID: nodeID,
ApplicationID: appID,
PartitionName: "default",
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1
```
</details>
###### TravisBuddy Request Identifier: 747e2b30-b74a-11ea-90cf-99978df78ba0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649896543
Hey @yangwwei,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/702230568">View build log</a>
###### TravisBuddy Request Identifier: 6c7ef030-b74b-11ea-90cf-99978df78ba0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649893397
## Travis tests have failed
Hey @yangwwei,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
### 1st Build
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/jobs/702228937">View build log</a>
<details>
<summary>
<strong>
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
</strong>
</summary>
```
golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
```
</details>
<details>
<summary>
<strong>
make lint
</strong>
</summary>
```
running golangci-lint
pkg/cache/partition_info_test.go:514: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
AllocationKey: allocationUUID1,
AllocationTags: map[string]string{"a": "b"},
UUID: allocationUUID1,
ResourcePerAlloc: alloc1Res,
Priority: nil,
QueueName: queueName,
NodeID: nodeID,
ApplicationID: appID,
PartitionName: "default",
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1
```
</details>
###### TravisBuddy Request Identifier: ce1a7f00-b749-11ea-90cf-99978df78ba0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #179: [YUNIKORN-251] yunikorn-core recovers allocation UUID from the reported existing allocations
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #179:
URL: https://github.com/apache/incubator-yunikorn-core/pull/179#issuecomment-649923006
Hey @yangwwei,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/702242764">View build log</a>
###### TravisBuddy Request Identifier: c1484c40-b757-11ea-90cf-99978df78ba0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org