[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2319: Add Bitmap index reader

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2319: Add Bitmap index reader
URL: https://github.com/apache/incubator-doris/pull/2319#discussion_r352553188
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/segment_writer.cpp
 ##########
 @@ -63,6 +63,9 @@ Status SegmentWriter::init(uint32_t write_mbytes_per_sec) {
             opts.need_zone_map = true;
         }
         // TODO set opts.need_bitmap_index based on table properties
+        if (!column.is_key()) {
 
 Review comment:
   Currently, it's mainly for UT. which column will have inverted index is decided by FE. After FE work done, this condition could remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org