[GitHub] [skywalking-eyes] emschu edited a comment on pull request #40: [PREVIEW] Add support for PHP

[GitBox <gi...@apache.org>]

emschu edited a comment on pull request #40:
URL: https://github.com/apache/skywalking-eyes/pull/40#issuecomment-877169151


   @kezhenxu94 Yes, your example is a valid php script syntax. You can read about this topic [here](https://www.php.net/manual/en/language.basic-syntax.phptags.php).
   
   > If a file contains only PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script.
   
   For this reason I think it is not a good idea to generally add a php closing tag after the license header in PHP files as this could cause trouble with whitespace or output buffering in pure php files (*pure* means: non-template PHP code, e.g. class definitions etc.).
   
   I will think about this problem next week again. Enjoy the weekend!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org