[GitHub] a2l007 commented on a change in pull request #6285: Securing passwords used for SSL connections to Kafka

[GitBox <gi...@apache.org>]

a2l007 commented on a change in pull request #6285: Securing passwords used for SSL connections to Kafka
URL: https://github.com/apache/incubator-druid/pull/6285#discussion_r216140822
 
 

 ##########
 File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTask.java
 ##########
 @@ -282,24 +289,36 @@ StreamAppenderatorDriver newDriver(
     );
   }
 
-  KafkaConsumer<byte[], byte[]> newConsumer()
+  KafkaConsumer<byte[], byte[]> newConsumer() throws IOException
   {
     ClassLoader currCtxCl = Thread.currentThread().getContextClassLoader();
     try {
       Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
 
-      final Properties props = new Properties();
-
-      for (Map.Entry<String, String> entry : ioConfig.getConsumerProperties().entrySet()) {
-        props.setProperty(entry.getKey(), entry.getValue());
+      final Map<String, Object> configs = new HashMap<>();
 
 Review comment:
   Since the json for consumerProperties would be as follows,
   ```
   "consumerProperties": {
         "ssl.truststore.password": {
           "type": "foo",
           "passwordKey": "foo_key"
         }
       }
   ```
   I used `Object` for it to get deserialized properly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org