You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Mukul Joshi (JIRA)" <ji...@apache.org> on 2012/08/30 14:11:08 UTC

[jira] [Created] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Mukul Joshi created ISIS-255:
--------------------------------

             Summary: Test in Runtime TestSupport component fails due to TimeZone
                 Key: ISIS-255
                 URL: https://issues.apache.org/jira/browse/ISIS-255
             Project: Isis
          Issue Type: Bug
          Components: Runtimes: Dflt
    Affects Versions: 0.3.1-incubating
         Environment: Win 7, Jdk 1.7, IST TimeZone
            Reporter: Mukul Joshi
            Priority: Minor
             Fix For: 0.3.1-incubating


Error in the build of the testsupport component as follows:
 
loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>

This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
 
The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():

Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());

Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Mukul Joshi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444900#comment-13444900 ] 

Mukul Joshi commented on ISIS-255:
----------------------------------

Comment from Dan:

The simplest short-term fix for this defect might be to use
assumeThat(...), so that the test is skipped if your timezone is not BST.

Something like (in pseudo code):

assumeThat(TimeZone.currentTimeZone().getName(), is("GMT"));


Please raise a JIRA ticket to have this fixed, and - if you have the time -
attach the assumeThat(...) workaround as a patch so we could apply it.
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-255.
------------------------------

    Resolution: Fixed

to be honest, the patches applied workaround the problem rather than fix it.  But hopefully we'll move onto joda time (or javax.time) in the future, rendering this particular issue moot.
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Assignee: Dan Haywood
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java, ObjectFixtureFilePersistorTest.patch
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Mukul Joshi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukul Joshi updated ISIS-255:
-----------------------------

    Attachment: ObjectFixtureFilePersistorTest.patch

The patch for the ObjectFixtureFilePersistorTest.java related to the workaround to skip test in case TimeZone is not GMT
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java, ObjectFixtureFilePersistorTest.patch
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447428#comment-13447428 ] 

Dan Haywood commented on ISIS-255:
----------------------------------

now made assumeThat(...) to exclude all tests if not in GMT.  r1380404 ~ 1380408
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Assignee: Dan Haywood
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java, ObjectFixtureFilePersistorTest.patch
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood reassigned ISIS-255:
--------------------------------

    Assignee: Dan Haywood
    
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Assignee: Dan Haywood
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java, ObjectFixtureFilePersistorTest.patch
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Mukul Joshi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444902#comment-13444902 ] 

Mukul Joshi commented on ISIS-255:
----------------------------------

Attaching the modified ObjectFixtureFilePersistorTest.java which has the work around as suggested by Dan
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446152#comment-13446152 ] 

Dan Haywood commented on ISIS-255:
----------------------------------

applied, rev 1379518

Thanks for this, Mukul.

                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java, ObjectFixtureFilePersistorTest.patch
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ISIS-255) Test in Runtime TestSupport component fails due to TimeZone

Posted by "Mukul Joshi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukul Joshi updated ISIS-255:
-----------------------------

    Attachment: ObjectFixtureFilePersistorTest.java

The modified ObjectFixtureFilePersistorTest.java to skip the test for date check if the TimeZone is not GMT
                
> Test in Runtime TestSupport component fails due to TimeZone
> -----------------------------------------------------------
>
>                 Key: ISIS-255
>                 URL: https://issues.apache.org/jira/browse/ISIS-255
>             Project: Isis
>          Issue Type: Bug
>          Components: Runtimes: Dflt
>    Affects Versions: 0.3.1-incubating
>         Environment: Win 7, Jdk 1.7, IST TimeZone
>            Reporter: Mukul Joshi
>            Priority: Minor
>              Labels: test
>             Fix For: 0.3.1-incubating
>
>         Attachments: ObjectFixtureFilePersistorTest.java
>
>
> Error in the build of the testsupport component as follows:
>  
> loadInstance(org.apache.isis.runtimes.dflt.runtime.fixturedomainservice.ObjectFixtureFilePersistorTest): expected:<Mon Mar 08 06:30:00 IST 2010> but was:<Mon Mar 08 01:00:00 IST 2010>
> This is because my Time Zone is IST. If I set my Time Zone to GMT then the test passes
>  
> The error comes at this line in the class ObjectFixtureFilePersistorTest and method loadInstance():
> Assert.assertEquals(dateFormat.parse("08-Mar-2010 01:00 GMT"), epv.getDate());
> Here the epv.getData() returns date in IST and the code getting executed is from the SimpleEntity getDate() method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira