You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/08 19:47:23 UTC
[GitHub] [hudi] jonvex opened a new pull request, #7164: [HUDI-5036] Update contribution guide based on PR validation
jonvex opened a new pull request, #7164:
URL: https://github.com/apache/hudi/pull/7164
### Change Logs
Added some bullet points to help contributors to fill out title and template correctly so that they are less likely to get stuck trying to get pr compliance to pass.
### Impact
Should help developers create pr's easier.
### Risk level (write none, low medium or high below)
none
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #7164: [HUDI-5036] Update contribution guide based on PR validation
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7164:
URL: https://github.com/apache/hudi/pull/7164#discussion_r1020204857
##########
website/contribute/developer-setup.md:
##########
@@ -139,7 +139,10 @@ and more importantly also try to improve the process along the way as well.
- Sending a Pull Request
- Format commit and the pull request title like `[HUDI-XXX] Fixes bug in Spark Datasource`,
where you replace `HUDI-XXX` with the appropriate JIRA issue.
+ - Pull request titles must have either `[HUDI-XXX]` or `[MINOR]` in their title. Note the brackets and capitalization.
- Please ensure your commit message body is descriptive of the change. Bulleted summary would be appreciated.
+ - You must follow the instructions in the template and fill out all fields to pass our compliance checks.
+ - Do not remove or modify any headings in the template.
Review Comment:
We allow `Risk level` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex commented on a diff in pull request #7164: [HUDI-5036] Update contribution guide based on PR validation
Posted by GitBox <gi...@apache.org>.
jonvex commented on code in PR #7164:
URL: https://github.com/apache/hudi/pull/7164#discussion_r1020347549
##########
website/contribute/developer-setup.md:
##########
@@ -139,7 +139,10 @@ and more importantly also try to improve the process along the way as well.
- Sending a Pull Request
- Format commit and the pull request title like `[HUDI-XXX] Fixes bug in Spark Datasource`,
where you replace `HUDI-XXX` with the appropriate JIRA issue.
+ - Pull request titles must have either `[HUDI-XXX]` or `[MINOR]` in their title. Note the brackets and capitalization.
- Please ensure your commit message body is descriptive of the change. Bulleted summary would be appreciated.
+ - You must follow the instructions in the template and fill out all fields to pass our compliance checks.
+ - Do not remove or modify any headings in the template.
Review Comment:
You can get rid of (write none, low medium or high below) but you still need the Risk Level heading, and you could remove documentation update entirely and validation will still pass. But I think the instruction is easier to follow if we just say don't modify any of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #7164: [HUDI-5036] Update contribution guide based on PR validation
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #7164:
URL: https://github.com/apache/hudi/pull/7164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org