You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 15:31:22 UTC

[GitHub] [airflow] HappinessInAutism opened a new pull request #13894: critical class definition issue

HappinessInAutism opened a new pull request #13894:
URL: https://github.com/apache/airflow/pull/13894


   `getattr(parent, 'text')` at https://github.com/apache/airflow/blob/master/airflow/models/baseoperator.py#L870
   
   will always raise `AttributeError: 'TelegramOperator' object has no attribute 'text'`
   
   **TelegramOperator** actually does not have such an attribute(`self.text`)
   
   issue occured while these valid arguments were passed to the operator: _token_, _chat_id_, _text_
   
   the same argument set worked as intended right after that fix
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#discussion_r565715583



##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -61,6 +61,7 @@ def __init__(
         **kwargs,
     ):
         self.chat_id = chat_id
+        self.text = text

Review comment:
       Ahh.... I know what happened. You should make a slight different change.
   ```
   -    template_fields = ('text', 'chat_id')
   +    template_fields = ('telegram_kwargs', 'chat_id')
   ```
   or move the following part of code to execute method:
   ```
           if text is not None:
               self.telegram_kwargs['text'] = text
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#discussion_r565712921



##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -61,6 +61,7 @@ def __init__(
         **kwargs,
     ):
         self.chat_id = chat_id
+        self.text = text

Review comment:
       Why was this problem not detected by unit tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#discussion_r563839592



##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -61,6 +61,7 @@ def __init__(
         **kwargs,
     ):
         self.chat_id = chat_id
+        self.text = text or None

Review comment:
       ```suggestion
           self.text = text
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#issuecomment-766897966

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#issuecomment-766897966

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jhtimmins commented on pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

jhtimmins commented on pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#issuecomment-778742923


   @HappinessInAutism Are you still interested in updating this PR and making the change?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#issuecomment-811546288


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #13894:
URL: https://github.com/apache/airflow/pull/13894#discussion_r563839592



##########
File path: airflow/providers/telegram/operators/telegram.py
##########
@@ -61,6 +61,7 @@ def __init__(
         **kwargs,
     ):
         self.chat_id = chat_id
+        self.text = text or None

Review comment:
       ```suggestion
           self.text = text
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] closed pull request #13894: critical class definition issue

Posted by GitBox <gi...@apache.org>.

github-actions[bot] closed pull request #13894:
URL: https://github.com/apache/airflow/pull/13894


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org