[gobblin] branch master updated: [GOBBLIN-1670] Remove rat tasks and unneeded checkstyles blocking build pipeline (#3529)

[zi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zihanli58 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 2983607a7 [GOBBLIN-1670] Remove rat tasks and unneeded checkstyles blocking build pipeline (#3529)
2983607a7 is described below

commit 2983607a7963ffccefeb5d66dd256e7079987b87
Author: William Lo <lo...@gmail.com>
AuthorDate: Thu Jul 21 09:41:09 2022 -0700

    [GOBBLIN-1670] Remove rat tasks and unneeded checkstyles blocking build pipeline (#3529)
    
    * Remove rat task on ci-cd
    
    * Disable checkstyle for generated code
    
    * Remove checkstyle on generated rest files as well
    
    * Fix checkstyle for generated java code
    
    * Remove checkstyle for gobblin-metrics-base generated code
    
    * Remove checkstyle for generated code in test utils and http
---
 .github/workflows/build_and_test.yaml                  | 5 +++--
 gobblin-metrics-libs/gobblin-metrics-base/build.gradle | 2 ++
 gobblin-modules/gobblin-http/build.gradle              | 2 ++
 gobblin-modules/gobblin-metrics-hadoop/build.gradle    | 2 +-
 gobblin-modules/gobblin-metrics-influxdb/build.gradle  | 2 +-
 gobblin-runtime/build.gradle                           | 3 ++-
 gobblin-test-utils/build.gradle                        | 2 ++
 7 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
index aec287355..c2fdf7bbc 100644
--- a/.github/workflows/build_and_test.yaml
+++ b/.github/workflows/build_and_test.yaml
@@ -57,7 +57,8 @@ jobs:
           restore-keys: ${{ runner.os }}-gradle
       - name: Build repository
         run: |
-          ./gradlew --no-daemon clean build -x test -x javadoc -x findbugsMain -x findbugsTest -x checkstyleMain -x checkstyleJmh -x checkstyleTest -Dorg.gradle.parallel=true
+          ./gradlew --no-daemon clean build -x test -x rat -x javadoc -x findbugsMain -x findbugsTest -x checkstyleMain \
+          -x checkstyleJmh -x checkstyleTest -x checkstyleMainGeneratedDataTemplate -x checkstyleMainGeneratedRest -Dorg.gradle.parallel=true
       - name: Verify Dependencies
         run: |
           # Since dependencies are cached, check after building if they are valid or not
@@ -86,7 +87,7 @@ jobs:
           restore-keys: ${{ runner.os }}-gradle
       - name: Run CheckStyle and FindBugs
         run: |
-          ./gradlew --no-daemon javadoc findbugsMain checkstyleMain checkstyleTest checkstyleJmh
+          ./gradlew --no-daemon javadoc findbugsMain checkstyleMain checkstyleTest checkstyleJmh 
 
   run_tests:
     timeout-minutes: 120
diff --git a/gobblin-metrics-libs/gobblin-metrics-base/build.gradle b/gobblin-metrics-libs/gobblin-metrics-base/build.gradle
index 688972f59..69b634287 100644
--- a/gobblin-metrics-libs/gobblin-metrics-base/build.gradle
+++ b/gobblin-metrics-libs/gobblin-metrics-base/build.gradle
@@ -77,3 +77,5 @@ task performance(type: Test) {
 }
 
 ext.classification="library"
+// Ignore the generated java code and avro residing in main
+checkstyleMain.source = "src/main/java"
\ No newline at end of file
diff --git a/gobblin-modules/gobblin-http/build.gradle b/gobblin-modules/gobblin-http/build.gradle
index b183fdf44..2644d6247 100644
--- a/gobblin-modules/gobblin-http/build.gradle
+++ b/gobblin-modules/gobblin-http/build.gradle
@@ -73,3 +73,5 @@ sourceSets {
 }
 
 ext.classification="library"
+// Ignore the generated java code and avro residing in main
+checkstyleMain.source = "src/main/java"
\ No newline at end of file
diff --git a/gobblin-modules/gobblin-metrics-hadoop/build.gradle b/gobblin-modules/gobblin-metrics-hadoop/build.gradle
index 71b1f7d8a..f6b5f1e8c 100644
--- a/gobblin-modules/gobblin-metrics-hadoop/build.gradle
+++ b/gobblin-modules/gobblin-metrics-hadoop/build.gradle
@@ -47,4 +47,4 @@ test {
     maxParallelForks = 1
 }
 
-ext.classification="library"
+ext.classification="library"
\ No newline at end of file
diff --git a/gobblin-modules/gobblin-metrics-influxdb/build.gradle b/gobblin-modules/gobblin-metrics-influxdb/build.gradle
index f60332982..bcf8ab8d0 100644
--- a/gobblin-modules/gobblin-metrics-influxdb/build.gradle
+++ b/gobblin-modules/gobblin-metrics-influxdb/build.gradle
@@ -48,4 +48,4 @@ test {
     maxParallelForks = 1
 }
 
-ext.classification="library"
+ext.classification="library"
\ No newline at end of file
diff --git a/gobblin-runtime/build.gradle b/gobblin-runtime/build.gradle
index 254ba7cc7..8149129e1 100644
--- a/gobblin-runtime/build.gradle
+++ b/gobblin-runtime/build.gradle
@@ -179,7 +179,6 @@ clean {
 }
 
 ext.classification="library"
-
 /**
  * Converts old style pull files into *.conf with templates
  *
@@ -216,3 +215,5 @@ task pullFileConverter(type: JavaExec) {
   }
 
 }
+// Ignore the generated java code and avro residing in main
+checkstyleMain.source = "src/main/java"
diff --git a/gobblin-test-utils/build.gradle b/gobblin-test-utils/build.gradle
index 7239e45ba..ee5817b91 100644
--- a/gobblin-test-utils/build.gradle
+++ b/gobblin-test-utils/build.gradle
@@ -101,3 +101,5 @@ findbugs {
 }
 
 ext.classification="library"
+// Ignore the generated java code and avro residing in main
+checkstyleMain.source = "src/main/java"
\ No newline at end of file