You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/10 23:38:50 UTC

[GitHub] [arrow-rs] sunchao commented on a change in pull request #1423: Directly write to MutableBuffer in substring

sunchao commented on a change in pull request #1423:
URL: https://github.com/apache/arrow-rs/pull/1423#discussion_r824268996



##########
File path: arrow/src/util/bench_util.rs
##########
@@ -94,6 +94,15 @@ where
 pub fn create_string_array<Offset: StringOffsetSizeTrait>(
     size: usize,
     null_density: f32,
+) -> GenericStringArray<Offset> {
+    create_string_array_with_len(size, null_density, 4)
+}
+
+/// Creates an random (but fixed-seeded) array of a given size, null density and length of string

Review comment:
       nit: "a random"
   
   Maybe: "Creates a random (but fixed-seeded) array of strings with given size, null density and length"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org