You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by gr...@apache.org on 2010/06/18 09:04:50 UTC

svn commit: r955859 - in /logging/log4php/trunk/src: changes/changes.xml main/php/appenders/LoggerAppenderPDO.php

Author: grobmeier
Date: Fri Jun 18 07:04:49 2010
New Revision: 955859

URL: http://svn.apache.org/viewvc?rev=955859&view=rev
Log:
LOG4PHP-115: added patch from Vaceletm. Cursor needs to be closed after checking if a table exists

Modified:
    logging/log4php/trunk/src/changes/changes.xml
    logging/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php

Modified: logging/log4php/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/changes/changes.xml?rev=955859&r1=955858&r2=955859&view=diff
==============================================================================
--- logging/log4php/trunk/src/changes/changes.xml (original)
+++ logging/log4php/trunk/src/changes/changes.xml Fri Jun 18 07:04:49 2010
@@ -24,6 +24,7 @@
   </properties>
   <body>
   	<release version="2.1" description="Stabilizing">
+  		<action type="fix" issue="LOG4PHP-115" by="Vaceletm">Instanciate LoggerAppenderPDO by hand throw exception</action>
   		<action type="update" issue="LOG4PHP-36" by="Moritz Schmidt">PHP Configurator: set remaining properties to appenders</action>
   		<action type="update" issue="LOG4PHP-110" by="Vladimir Gorej">MongoDB: improved exception handling</action>
   		<action type="fix" issue="LOG4PHP-112" by="darja, Christian Grobmeier">Logging ClassName doesn't work</action>

Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php?rev=955859&r1=955858&r2=955859&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php (original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php Fri Jun 18 07:04:49 2010
@@ -126,6 +126,7 @@ class LoggerAppenderPDO extends LoggerAp
             // test if log table exists
             try {
                 $result = $this->db->query('SELECT * FROM ' . $this->table . ' WHERE 1 = 0');
+                $result->closeCursor(); 
             } catch (PDOException $e) {
                 // It could be something else but a "no such table" is the most likely
                 $result = false;