You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 08:39:04 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
MaxGekk opened a new pull request #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964
### What changes were proposed in this pull request?
1. The tests added by #27953 are moved from `AvroLogicalTypeSuite` to `AvroSuite`.
2. Checking of the `rebaseDateTime` flag is moved out from functions bodies.
### Why are the changes needed?
1. The tests are moved because they are not directly related to logical types.
2. Checking the flag out of functions bodies should improve performance.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By running Avro tests via the command `build/sbt avro/test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602150985
The problem is commits of this PR in master and in branch-3.0 are different:
master:
DateTimeUtils.microsToMillis at https://github.com/apache/spark/commit/b402bc900ab89e6fceb9b0a37c597e8914864f11#diff-01fea32e6ec6bcf6f34d06282e08705aR155
branch-3.0:
DateTimeUtils.fromMillis at https://github.com/apache/spark/commit/a6f3e3b096e2d7a39e0b2fdec6452e6d633baf7e#diff-01fea32e6ec6bcf6f34d06282e08705aR155
The `fromMillis()` in branch-3.0 is `millisToMicros()` but not `microsToMillis()` actually. The renaming was done in master by https://github.com/apache/spark/pull/27618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24802/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601602149
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601602158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120085/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601588394
@HyukjinKwon @cloud-fan Please, review the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602143661
Hi, All.
This seems to break all eight Jenkins jobs on `branch-3.0` consistently.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-sbt-hadoop-3.2-hive-2.3/223/
```
org.apache.spark.sql.avro.AvroV1LogicalTypeSuite.Logical type: user specified output schema with different timestamp types
org.apache.spark.sql.avro.AvroV1Suite.SPARK-31183: rebasing milliseconds timestamps in write
org.apache.spark.sql.avro.AvroV2LogicalTypeSuite.Logical type: user specified output schema with different timestamp types
org.apache.spark.sql.avro.AvroV2Suite.SPARK-31183: rebasing milliseconds timestamps in write
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602143946
The answers are different. It seems that we need more date-time related patches at `branch-3.0`. I'm not sure what it is.
```
!== Correct Answer - 2 == == Spark Answer - 2 ==
!struct<> struct<timestamp_millis:timestamp,timestamp_micros:timestamp>
![1969-12-31 16:00:01.0,1969-12-31 16:00:02.0] [1969-12-31 16:00:01.0,1970-01-23 19:33:20.0]
![1969-12-31 16:11:06.0,1969-12-31 16:16:39.0] [1969-12-31 16:11:06.0,2001-08-28 05:00:00.0]
```
Given the above, I'll try to recover `branch-3.0` first by reverting this. Please make a separate PR on `branch-3.0` to see the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601601605
**[Test build #120085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120085/testReport)** for PR 27964 at commit [`556d438`](https://github.com/apache/spark/commit/556d43814f7476366ca9fa271374684563b280fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589072
**[Test build #120085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120085/testReport)** for PR 27964 at commit [`556d438`](https://github.com/apache/spark/commit/556d43814f7476366ca9fa271374684563b280fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602146652
Thanks @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601602149
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24802/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602143661
Hi, All.
This seems to break all Jenkins job on `branch-3.0` consistently.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-sbt-hadoop-3.2-hive-2.3/223/
```
org.apache.spark.sql.avro.AvroV1LogicalTypeSuite.Logical type: user specified output schema with different timestamp types
org.apache.spark.sql.avro.AvroV1Suite.SPARK-31183: rebasing milliseconds timestamps in write
org.apache.spark.sql.avro.AvroV2LogicalTypeSuite.Logical type: user specified output schema with different timestamp types
org.apache.spark.sql.avro.AvroV2Suite.SPARK-31183: rebasing milliseconds timestamps in write
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601602158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120085/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602153140
Ah, sorry, seems it was my mistake. Thanks @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601618677
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-602152201
Here is the backport of this PR with bug fix: https://github.com/apache/spark/pull/27977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27964:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27964: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27964#issuecomment-601589072
**[Test build #120085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120085/testReport)** for PR 27964 at commit [`556d438`](https://github.com/apache/spark/commit/556d43814f7476366ca9fa271374684563b280fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org