You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/27 12:08:48 UTC
[GitHub] [mynewt-core] nkaje opened a new pull request #2296: crypto_test: add syscfg option to use RAM based input
nkaje opened a new pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296
Some targets (such as Dialog DA1469x), Crypto block can not
readily access the input buffer in flash. In most use-cases,
the buffers reside in RAM. Add a syscfg option to move the input
to RAM before invoking crypto functions. By default this
config is disabled.
Signed-off-by: Naveen Kaje <na...@juul.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2296: crypto_test: add syscfg option to use RAM based input
Posted by GitBox <gi...@apache.org>.
utzig commented on pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296#issuecomment-634816744
> I'm not convinced that this is correct solution to problem.
This is not a driver, it's a test app, and I believe this is a reasonable trade-off to have as optional while developing a driver further. The da1469x can use flash as input for the crypto unit as long as the proper memory mappings are done, which is not available just yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on pull request #2296: crypto_test: add syscfg option to use RAM based input
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296#issuecomment-634716468
I'm not convinced that this is correct solution to problem.
If accessing flash is problematic on some platform driver for this platform should have this switch inside.
Considering that additional buffer is taken from stack it would not matter if this stack was allocated from stack in driver code.
If test application can suffer from bad memory access so can any other user app, so why apply cure to this test app only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2296: crypto_test: add syscfg option to use RAM based input
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296#issuecomment-634626067
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] nkaje commented on pull request #2296: crypto_test: add syscfg option to use RAM based input
Posted by GitBox <gi...@apache.org>.
nkaje commented on pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296#issuecomment-656165141
https://github.com/apache/mynewt-core/pull/2327 is added to check the address and mapping in the crypto driver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] nkaje closed pull request #2296: crypto_test: add syscfg option to use RAM based input
Posted by GitBox <gi...@apache.org>.
nkaje closed pull request #2296:
URL: https://github.com/apache/mynewt-core/pull/2296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org