You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/01 02:37:00 UTC

[jira] [Work logged] (SSHD-1257) Shell is not getting closed if the command has already closed the OutputStream it is using.

     [ https://issues.apache.org/jira/browse/SSHD-1257?focusedWorklogId=751353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751353 ]

ASF GitHub Bot logged work on SSHD-1257:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/22 02:36
            Start Date: 01/Apr/22 02:36
    Worklog Time Spent: 10m 
      Work Description: lgoldstein commented on a change in pull request #214:
URL: https://github.com/apache/mina-sshd/pull/214#discussion_r840186180



##########
File path: sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelSession.java
##########
@@ -908,7 +908,7 @@ protected void closeShell(int exitValue, boolean closeImmediately) throws IOExce
 
         if (!isClosing()) {
             if (out != null) {
-                out.flush();

Review comment:
       Not sure about this... "smells fishy" as well , though I cannot put my fiinger on it - will have to think about it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 751353)
    Time Spent: 1.5h  (was: 1h 20m)

> Shell is not getting closed if the command has already closed the OutputStream it is using.
> -------------------------------------------------------------------------------------------
>
>                 Key: SSHD-1257
>                 URL: https://issues.apache.org/jira/browse/SSHD-1257
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.9.0
>            Reporter: Vincent Latombe
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When running a org.apache.sshd.server.command.Command, if it happens to close the OutputStream instance it is using, then later when the ssh session closes, it attempts to flush the output stream before closing it.
> This causes theĀ  following warning to be printed on server side
> {code:java}
> WARNING o.a.s.s.channel.ChannelSession#lambda$prepareCommand$0: onExit(ChannelSession[id=0, recipient=0]-ServerSessionImpl[admin@/0:0:0:0:0:0:0:1:49944]) code=0 message='' SshChannelClosedException closing shell: flush(ChannelOutputStream[ChannelSession[id=0, recipient=0]-ServerSessionImpl[admin@/0:0:0:0:0:0:0:1:49944]] SSH_MSG_CHANNEL_DATA) length=0 - stream is already closed
> {code}
> and EOF is never sent to client.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org